Skip to content

[BUG] when a filter is removed the data does not refresh #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmarchetti00 opened this issue Dec 23, 2021 · 4 comments
Open

[BUG] when a filter is removed the data does not refresh #33

tmarchetti00 opened this issue Dec 23, 2021 · 4 comments
Assignees
Labels
bug Something isn't working Next Release An issue that will be fixed or a new feature that will be added to one of the next versions of the s

Comments

@tmarchetti00
Copy link

Version used
Ex: 1.3.2

Problem:
When I apply a filter such as COVID and then remove the filter the Apply button is greyed out and the data does not refresh back to the original search result. If I add COVID filter again the Apply button is still greyed out. I have to click the Clear button after I remove the filter. Is there a way to make that Clear button a bit more prominent via color that it’s active or anyway to force a refresh/clear?

Steps to reproduce:

  1. Set up a non-taxonomy, multi-select field
  2. Select multiple terms and click highlighted Apply button.
  3. Delete a term by clicking the X on the term ‘pill’.
  4. Note that Apply is highlighted.
  5. Repeat till you have individually deleted and applied each term. Last term still has Apply as a highlighted option:

image

Next, do the same thing with a taxonomy, multi-select field

  1. Set up a taxonomy, multi-select field
  2. Select multiple terms and click highlighted Apply button.
  3. Delete a term by clicking the X on the term ‘pill’.
  4. Note that Apply is highlighted.

image

  1. Repeat till you have individually deleted and applied each term. When you’re down to a single term, the Apply button is not highlighted. You have to click the un-highlighted Clear button to clear that last term.

image

NOTE: When you click the “Show selected filters” filter icon (at the top of the Search results web part) all filters are cleared Without having to click apply, regardless of whether the fields are single or multi select. Can the Filter selections have the same behavior. If you click on the “X” to close a term, have the close applied without having to click Apply?

@tmarchetti00 tmarchetti00 added the bug Something isn't working label Dec 23, 2021
@Laul0 Laul0 self-assigned this Jan 3, 2022
@Laul0
Copy link
Collaborator

Laul0 commented Jan 19, 2022

Hi @tmarchetti00, thank you for your feedback, it is really important for us.
We will try to reproduce the same behavior on our side and keep you in touch.

@Laul0 Laul0 assigned yhabersaat and unassigned FranckyC Feb 3, 2022
@yhabersaat yhabersaat removed their assignment Feb 6, 2022
@yhabersaat yhabersaat self-assigned this Feb 15, 2022
@Laul0 Laul0 added the Next Release An issue that will be fixed or a new feature that will be added to one of the next versions of the s label Mar 1, 2022
@Laul0
Copy link
Collaborator

Laul0 commented Mar 31, 2022

This issue should be fixed with the latest release today. Feel free to reopen this issue if the problem persists.

@Laul0 Laul0 closed this as completed Mar 31, 2022
@ghost
Copy link

ghost commented Apr 28, 2022

Hi @Laul0 - could we re-open this please? We're still seeing the same bug/inconsistency as in the reproduction steps.

@Laul0
Copy link
Collaborator

Laul0 commented Apr 29, 2022

Hi @randhawaryan,

Yes, we can reopen it. We will try on our side again to ensure that the behavior is correct or not.

@Laul0 Laul0 reopened this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Next Release An issue that will be fixed or a new feature that will be added to one of the next versions of the s
Projects
None yet
Development

No branches or pull requests

4 participants