From 73b5b1eb2cd76214b6c3445a0bebef50181ca39b Mon Sep 17 00:00:00 2001
From: Stephen Coady <scoady@redhat.com>
Date: Wed, 15 May 2019 09:56:28 +0100
Subject: [PATCH] fix: optimistic response id check fixed

---
 packages/sync/src/cache/createMutationOptions.ts    | 10 +++++++++-
 packages/sync/src/cache/createOptimisticResponse.ts |  2 +-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/packages/sync/src/cache/createMutationOptions.ts b/packages/sync/src/cache/createMutationOptions.ts
index 34bee505..ae28876f 100644
--- a/packages/sync/src/cache/createMutationOptions.ts
+++ b/packages/sync/src/cache/createMutationOptions.ts
@@ -19,11 +19,19 @@ export const createMutationOptions = (options: MutationHelperOptions): MutationO
     mutation,
     variables,
     updateQuery,
+    typeName,
     operationType = CacheOperation.ADD,
     idField = "id"
   } = options;
   const operationName = getOperationFieldName(mutation);
-  const optimisticResponse = createOptimisticResponse(options);
+  const optimisticResponse = createOptimisticResponse({
+    mutation,
+    variables,
+    updateQuery,
+    operationType,
+    idField,
+    typeName
+  });
 
   const update = getUpdateFunction(operationName, idField, updateQuery, operationType);
   return { mutation, variables, optimisticResponse, update };
diff --git a/packages/sync/src/cache/createOptimisticResponse.ts b/packages/sync/src/cache/createOptimisticResponse.ts
index 568b76da..4c1f0f22 100644
--- a/packages/sync/src/cache/createOptimisticResponse.ts
+++ b/packages/sync/src/cache/createOptimisticResponse.ts
@@ -59,7 +59,7 @@ export const createOptimisticResponse = (options: MutationHelperOptions) => {
       ...variables,
       optimisticResponse: true
     };
-    if (operationType !== CacheOperation.REFRESH) {
+    if (operationType === CacheOperation.ADD) {
       optimisticResponse[operation][idField] = generateId();
     }