Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docker volumes instead of binds for video recording #1315

Open
elvovsky opened this issue Feb 26, 2023 · 10 comments
Open

Use Docker volumes instead of binds for video recording #1315

elvovsky opened this issue Feb 26, 2023 · 10 comments

Comments

@elvovsky
Copy link

I have an install on windows running wsl2 and docker desktop. I had an issue and I had to reset docker desktop. Now after install it does not seem to see the config directory passed through cm parameter. I think what is missing is a mapping between the directory I am specifying in the parameter and the docker itself. Can you please guide me here ? Any help is appreciated !

@vania-pooh
Copy link
Member

@elvovsky any example commands are also appreciated. :)

@elvovsky
Copy link
Author

@vania-pooh Hello Ivan . From cm perspective the important parameter is --config-dir . The entire command is
cm.exe selenoid start --config-dir "C:\\selenoid\\config" --vnc --args "-limit 10 -session-attempt-timeout 2m -service-startup-timeout 2m -timeout 2m -cpu 1.0"
The output of the "docker ps" with no truncation is the following.
1a7e80b216e649a0ae984e0caa45c1cfd96411f608bd0fc3f53b46d07db37072 aerokube/selenoid:1.10.10 "/usr/bin/selenoid -listen :4444 -conf /etc/selenoid/browsers.json -video-output-dir /opt/selenoid/video/ -limit 10 -session-attempt-timeout 2m -service-startup-timeout 2m -timeout 2m -cpu 1.0 -conf /etc/selenoid/browsers.json -video-output-dir /opt/selenoid/video/ -video-recorder-image selenoid/video-recorder:latest-release -log-output-dir /opt/selenoid/logs/ -container-network selenoid" 2 minutes ago Up 2 minutes 0.0.0.0:4444->4444/tcp selenoid
I believe, There is supposed to be a mapping between /etc/selenoid/browsers.json and windows directory where it is located. Let me know if you need anything else.

@vania-pooh
Copy link
Member

@elvovsky I would try with --config-dir /c/selenoid/config.

@elvovsky
Copy link
Author

elvovsky commented Mar 1, 2023

@vania-pooh That did not work. It seemed to just add folders in windows. For now I ended up copying the browsers.josn I want under the default directory cm creates. I think this relates to the docker set up where it maps drive in windows to the linux wsl paths.

@vania-pooh
Copy link
Member

@elvovsky so this is resolved?

@elvovsky
Copy link
Author

elvovsky commented Mar 9, 2023

@vania-pooh Well, theoretically it is a work around. In my mind though this is docker volume translation issue and a setting of docker. I guess the workaround works, but ideally I would like to go back to a folder outside of a user profile

@vania-pooh vania-pooh changed the title Issue with config/browsers Use Docker volumes instead of binds for video recording Mar 10, 2023
@vania-pooh vania-pooh added this to the 1.11.0 milestone Mar 10, 2023
@vania-pooh
Copy link
Member

I would try to remove this old-style behavior completely and use Docker volumes instead.

@elvovsky
Copy link
Author

@vania-pooh I will see if i can get it upgraded and tested. Thanks !

@vania-pooh
Copy link
Member

@elvovsky implementing this is not as simple as we could imagine. Needs to think a bit more.

@elvovsky
Copy link
Author

@vania-pooh Understood. No issue

@vania-pooh vania-pooh modified the milestones: 1.11.0, 1.11.1 Jul 25, 2023
@vania-pooh vania-pooh removed this from the 1.11.2 milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants