Skip to content

Commit 95ec090

Browse files
committed
[CLIENT-3894] Setting user-agent allows a closed connection to return for tend
1 parent 120cea7 commit 95ec090

File tree

3 files changed

+28
-18
lines changed

3 files changed

+28
-18
lines changed

CHANGELOG.md

Lines changed: 22 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,30 @@
11
# Change History
22

3+
## November 14 2025: v8.4.2
4+
5+
**Fixes**
6+
- [CLIENT_3894] Setting user-agent allows a closed connection to return for tend.
7+
38
## November 4 2025: v8.4.1
4-
**Fixes**
5-
- [CLIENT-3821] Fixed issue where `panic: runtime error: invalid memory address` could occur after calling `usingTendConn(...)`.
9+
10+
**Fixes**
11+
- [CLIENT-3821] Fixed issue where `panic: runtime error: invalid memory address` could occur after calling `usingTendConn(...)`.
612

713
## October 20 2025: v8.4.0
8-
**Improvements**
9-
- [CLIENT-3435] Update Go client to support FIPS.
10-
11-
**Fixes**
12-
- [CLIENT-3821] Fixed issue where `Network Error from EOF` could occur after server migrations.
13-
- [CLIENT-3810] Fixed issue where nil pointer panic occurs on errToAerospikeErr.
14-
- [CLIENT-3796] Fixed issue where background queries for all records applied only partially.
15-
- [CLIENT-3744] Added server version check before sending the user-agent-set command.
16-
- [CLIENT-2418] Skipped orphan seeds without peers when other seeds have peers.
17-
- [CLIENT-3120] Replaced existing cluster node when a new peer shares the same node name but a different IP address.
18-
- [CLIENT-3546] Resolved inconsistencies between clients when reflecting configuration changes.
19-
- [CLIENT-3023] Fixed inability to repeat background queries using the same statement.
20-
- [CLIENT-3021] Ensured Statement.BinNames is empty for QueryExecute operations.
14+
15+
**Improvements**
16+
- [CLIENT-3435] Update Go client to support FIPS.
17+
18+
**Fixes**
19+
- [CLIENT-3821] Fixed issue where `Network Error from EOF` could occur after server migrations.
20+
- [CLIENT-3810] Fixed issue where nil pointer panic occurs on errToAerospikeErr.
21+
- [CLIENT-3796] Fixed issue where background queries for all records applied only partially.
22+
- [CLIENT-3744] Added server version check before sending the user-agent-set command.
23+
- [CLIENT-2418] Skipped orphan seeds without peers when other seeds have peers.
24+
- [CLIENT-3120] Replaced existing cluster node when a new peer shares the same node name but a different IP address.
25+
- [CLIENT-3546] Resolved inconsistencies between clients when reflecting configuration changes.
26+
- [CLIENT-3023] Fixed inability to repeat background queries using the same statement.
27+
- [CLIENT-3021] Ensured Statement.BinNames is empty for QueryExecute operations.
2128

2229
## August 29 2025: v8.3.0
2330

go.mod

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,7 @@ require (
2424
golang.org/x/tools v0.31.0 // indirect
2525
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c // indirect
2626
)
27+
28+
retract (
29+
[v8.3.0, v8.4.1] // Problem with User Agent code returning a closed connection without an error.
30+
)

node.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -527,12 +527,11 @@ func (nd *Node) newTendConnection() (*Connection, Error) {
527527
return nil, err
528528
}
529529

530-
serverMinVersion, _ := version.Parse("8.1.0.0")
530+
serverMinVersion := &version.Version{Major: 8, Minor: 1, Patch: 0, Build: 0}
531531
if nd.version.IsGreaterOrEqual(serverMinVersion) {
532532
if err := nd.sendUserAgentId(conn); err != nil {
533-
// If setting user agent failed, we still return the connection
534-
// as it is already authenticated and usable.
535533
logger.Logger.Warn("Error setting user agent for node %s: %s", nd.String(), err.Error())
534+
return nil, err
536535
}
537536
}
538537

0 commit comments

Comments
 (0)