fix: unreleased bug, deep copy new tls config fields (#82)

dwelch-spike · web-flow · commit f186d07d32b3 · 2023-12-08T12:36:16.000-08:00
* fix: deep copy new tls config fields to avoid double free
diff --git a/src/backup_status.c b/src/backup_status.c
@@ -486,6 +486,7 @@ backup_status_destroy(backup_status_t* status)
 	as_error ae;
 	aerospike_close(status->as, &ae);
 	aerospike_destroy(status->as);
+
 	cf_free(status->as);
 
 	as_exp_destroy(status->policy->base.filter_exp);
diff --git a/src/utils.c b/src/utils.c
@@ -2088,6 +2088,9 @@ tls_config_clone(as_config_tls* clone, const as_config_tls* src)
 	clone->keyfile = safe_strdup(src->keyfile);
 	clone->keyfile_pw = safe_strdup(src->keyfile_pw);
 	clone->certfile = safe_strdup(src->certfile);
+	clone->castring = safe_strdup(src->castring);
+	clone->certstring = safe_strdup(src->certstring);
+	clone->keystring = safe_strdup(src->keystring);
 }
 
 void

Original file line number	Diff line number	Diff line change
`@@ -2088,6 +2088,9 @@ tls_config_clone(as_config_tls* clone, const as_config_tls* src)`
`2088`	`2088`	`clone->keyfile = safe_strdup(src->keyfile);`
`2089`	`2089`	`clone->keyfile_pw = safe_strdup(src->keyfile_pw);`
`2090`	`2090`	`clone->certfile = safe_strdup(src->certfile);`
	`2091`	`+ clone->castring = safe_strdup(src->castring);`
	`2092`	`+ clone->certstring = safe_strdup(src->certstring);`
	`2093`	`+ clone->keystring = safe_strdup(src->keystring);`
`2091`	`2094`	`}`
`2092`	`2095`
`2093`	`2096`	`void`