fix: simplify getting tags

- previously it would use commit date. New version just does it by alphabet
- adds test for detached_tags

Author: fallion

.gitignore

@@ -1,2 +1,3 @@
 testdata/commits_on_branch/
 testdata/git_tags/
+testdata/detached_tags

pkg/get_tags.go

@@ -20,13 +20,7 @@ func (g *Git) getTags() ([]*Tag, error) {
 	var tags []*Tag
 
 	err = tagrefs.ForEach(func(t *plumbing.Reference) error {
-		commitDate, err := g.commitDate(t.Hash())
-
-		if err != nil {
-			return err
-		}
-
-		tags = append(tags, &Tag{Name: t.Name().String(), Date: commitDate, Hash: t.Hash()})
+		tags = append(tags, &Tag{Name: t.Name().String(), Hash: t.Hash()})
 		return nil
 	})
 
@@ -40,17 +34,18 @@ func (g *Git) getTags() ([]*Tag, error) {
 	if g.Debug {
 		log.Println("Sorted tag output: ")
 		for _, taginstance := range sortedTags {
-			log.Printf("hash: %v time: %v", taginstance.Hash, taginstance.Date.UTC())
+			log.Printf("hash: %v name: %v", taginstance.Hash, taginstance.Name)
 		}
 	}
 
 	return sortedTags, nil
 }
 
-// sortTags sorts the tags according to when their parent commit happened.
+// sortTags sorts the tags in reverse.
 func sortTags(repo *git.Repository, tags []*Tag) []*Tag {
 	sort.Slice(tags, func(i, j int) bool {
-		return tags[i].Date.After(tags[j].Date)
+		// Reverses the order
+		return j < i
 	})
 
 	return tags

pkg/previous_tag_test.go

@@ -24,3 +24,21 @@ func TestPreviousTag(t *testing.T) {
 	assert.Equal(t, "chore: first commit on master\n", commit.Message)
 
 }
+
+func TestPreviousTagDetachedTag(t *testing.T) {
+	repo, _ := git.PlainOpen("../testdata/detached_tags")
+	testGit := &Git{repo: repo, Debug: true}
+
+	head, err := repo.Head()
+
+	assert.NoError(t, err)
+
+	tag, err := testGit.PreviousTag(head.Hash())
+
+	assert.NoError(t, err)
+
+	commit, err := repo.CommitObject(tag.Hash)
+	assert.NoError(t, err)
+	assert.Equal(t, "chore: detached commit\n", commit.Message)
+
+}

pkg/tag.go

@@ -1,14 +1,11 @@
 package history
 
 import (
-	"time"
-
 	"gopkg.in/src-d/go-git.v4/plumbing"
 )
 
 // Tag houses some common info about tags.
 type Tag struct {
 	Name string
 	Hash plumbing.Hash
-	Date time.Time
 }

testdata/detached_tags.bundle

@@ -2,8 +2,8 @@
 
 rm -rf testdata/commits_on_branch
 rm -rf testdata/git_tags
+rm -rf testdata/detached_tags
 
-if [ ! -d './testdata/commits_on_branch' ]; then
   cd testdata
 
   echo 'testdata/commits_on_branch_test/ directory does not exist at the root; creating...'
@@ -13,8 +13,8 @@ if [ ! -d './testdata/commits_on_branch' ]; then
   echo 'testdata/git_tags/ directory does not exist at the root; creating...'
   git clone git_tags.bundle
   echo 'done'
-  
-else
-  echo 'testdata/commits_on_branch_test directory already exists; aborting.'
-  exit -1
-fi
+
+
+echo 'testdata/detached_tags/ directory does not exist at the root; creating...'
+  git clone detached_tags.bundle
+  echo 'done'