Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for Ubuntu Xenial Xerus 16.04 #40

Open
nmabhinandan opened this issue May 24, 2016 · 11 comments
Open

Build for Ubuntu Xenial Xerus 16.04 #40

nmabhinandan opened this issue May 24, 2016 · 11 comments
Assignees

Comments

@nmabhinandan
Copy link

No description provided.

@kshenoy
Copy link

kshenoy commented May 27, 2016

Seconded

@macbroadcast
Copy link

+1

@kshenoy
Copy link

kshenoy commented Aug 13, 2016

@daviip Thanks for responding, will give this a go.

First time ever really using git. Hope I'm doing it right.

I suppose you used backticks to demarcate the lines with code. It might be easier to just add 4 spaces at the beginning of the line to indicate it's code or add a line with 3 backticks before and after the code block. Eg.

This is a code block

Check out other styling options by clicking on the Styling with Markdown is supported link located below the edit box.

@sysfu
Copy link

sysfu commented Jan 26, 2017

I was able to get a build started on Loki after installing the following packages:
automake autoconf libtool-bin libunity-dev

...however it bails out with this error:

/usr/include/glib-2.0/glib/gstrfuncs.h:175:23: note: expected ‘gchar * {aka char *}’ but argument is of type ‘const gchar * {aka const char *}’
 gchar*                g_strchug        (gchar        *string);
                       ^
  CCLD     relay
main_window.o: In function `main_window_construct':
/usr/local/src/relay/build/src/../../src/main_window.c:1589: undefined reference to `gtk_widget_set_focus_on_click'

@sysfu
Copy link

sysfu commented Jan 26, 2017

Upon further investigation, the offending line 1589 in main_window.c uses 'gtk_widget_set_focus_on_click'
...and it appears that this function was not introduced until lib-gtk 3.20

The version of libgtk-3-dev that ships with Loki is 3.18:

$ dpkg --list | grep libgtk-3-dev
ii  libgtk-3-dev:amd64                             3.18.9-1ubuntu3.1 

So the solution appears to be either edit main_window.c and roll back the function name to 'gtk_button_set_focus_on_click' or build against a version of libgtk-3-dev that is v3.20 or newer.

@sysfu
Copy link

sysfu commented Jan 26, 2017

I went with editing main_window.c and was able to successfully build the app from source and install.

You'll probably want to copy or move the icon file too so it looks all purdy-like in the Applications menu:
sudo cp /usr/local/share/icons/hicolor/scalable/apps/relay.svg /usr/share/app-install/icons/relay.svg

@kshenoy
Copy link

kshenoy commented Jan 27, 2017

@sysfu

Upon further investigation, the offending line 1589 in main_window.c uses 'gtk_widget_set_focus_on_click'
...and it appears that this function was not introduced until lib-gtk 3.2

The version of libgtk-3-dev that ships with Loki is 3.18:

Wait! What? An older version of Elementary OS ships with a newer version of lib-gtk?

@sysfu
Copy link

sysfu commented Jan 27, 2017

My apologies, I left a zero off the version number, it should have been '3.20'. I have fixed it in the comment above as well as the link.

@agronick agronick self-assigned this Mar 14, 2017
@mauritslamers
Copy link

mauritslamers commented Apr 29, 2017

I would also love to see Relay for Loki. Is there anything any of us could do to help out?

@agronick
Copy link
Owner

agronick commented May 4, 2017

You could just make a PPA. All the sources are there.

@yerbestpal
Copy link

yerbestpal commented May 4, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants