adds check-compile target and fixes comp warnings

Author: agzam

Makefile

@@ -1,4 +1,5 @@
-.PHONY: help test
+
+.PHONY: help test deps check-compile
 
 define DEPS_SCRIPT
 (progn
@@ -14,8 +15,10 @@ export DEPS_SCRIPT
 
 help:
 	@echo "Available commands:"
-	@echo "  make deps    Install dependencies"
-	@echo "  make test    Run the tests"
+	@echo "  make deps          Install dependencies"
+	@echo "  make test          Run the tests"
+	@echo "  make compile       Byte-compile the package"
+	@echo "  make check-compile Check for clean byte-compilation"
 
 deps:
 	@echo "Installing dependencies"
@@ -25,3 +28,16 @@ test:
 	emacs --batch --funcall package-initialize --directory . \
 	--eval '(add-to-list '\''load-path "..")' \
 	--funcall buttercup-run-discover
+
+check-compile: deps
+	@echo "Checking byte-compilation..."
+	emacs -Q --batch \
+	--eval "(require 'package)" \
+	--eval "(setq package-user-dir \"$(CURDIR)/.elpa\")" \
+	--eval "(add-to-list 'package-archives '(\"melpa\" . \"http://melpa.org/packages/\"))" \
+	--eval "(package-initialize)" \
+	--eval "(package-install 'consult)" \
+	--eval "(package-install 'ts)" \
+	--eval "(setq byte-compile-error-on-warn t)" \
+	--eval "(add-to-list 'load-path \".\")" \
+	--eval "(byte-compile-file \"consult-hn.el\")"

consult-hn.el

@@ -206,6 +206,7 @@ timestamp value must be in utc timezone."
       found)))
 
 (defvar url-http-end-of-headers) ; used by url-http
+(defvar nb-pages)
 
 (defun consult-hn--fetch-page-async (input page async expected-search &optional buffer-callback)
   "Fetch a single page asynchronously.