Spotbugs upgrade to 4.6.0.0 for JDK 17

Author: aherbert

pom.xml

@@ -99,7 +99,7 @@ Measurement protocol to collect usage information from a Java application.
     <org.jacoco.version>0.8.7</org.jacoco.version>
     <org.junit.bom.version>5.7.0-M1</org.junit.bom.version>
     <pmd.version>6.26.0</pmd.version>
-    <spotbugs.version>4.0.4</spotbugs.version>
+    <spotbugs.version>4.6.0.0</spotbugs.version>
     <!-- Maven plugins -->
     <build-helper-maven-plugin.version>3.2.0</build-helper-maven-plugin.version>
     <formatter-maven-plugin.version>2.12.1</formatter-maven-plugin.version>

src/conf/spotbugs/spotbugs-exclude-filter.xml

@@ -36,4 +36,11 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
 
+  <Match>
+    <!-- False positive introduced in v4.6.0.0. The returned object is thread safe. -->
+    <Class name="uk.ac.sussex.gdsc.analytics.parameters.CacheBusterParameter"/>
+    <Method name="getDefaultInstance"/>
+    <BugPattern name="MS_EXPOSE_REP"/>
+  </Match>
+
 </FindBugsFilter>