Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get default values for new inputs #239

Open
giovannipizzi opened this issue Oct 19, 2021 · 0 comments
Open

Get default values for new inputs #239

giovannipizzi opened this issue Oct 19, 2021 · 0 comments
Labels
topic/protocol Issues related to protocols and their overrides

Comments

@giovannipizzi
Copy link
Member

There are some new inputs (like the kpoints mesh, smearing type, ...) where the default depends on the protocol and maybe on a few other options (e.g. ElectronicType).

For a user, or a GUI, it might be useful (given the protocol, and the basic inputs like the ElectronicType) to know which defaults the protocol will use for e.g. kpoints, smearing, ...

We need to define a way to get these - however, the question is how to do it, since it requires to get all the inputs that you would pass to the input generator in order to make that decision.

  • Should we pass all inputs also to these functions to get the default?
  • Should we change the behaviour of the InputGenerator Class, so you can set values (e.g. protocol, ElectronicType, ...) changing the state of the class, and only then either call get_default_smearing_type or directly get_builder() as a new call, without parameters?
  • Should we distinguish inputs in two kinds? The ones that are needed to provide the defaults (protocol, ElectronicType, ...) and the one that instead work as 'overrides' (kpoints-density, smearing-type, ...) for which we want to get the defaults? (See also Extended way of providing overrides #238)
@mbercx mbercx added topic/protocol Issues related to protocols and their overrides and removed topic/protocol Issues related to protocols and their overrides labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/protocol Issues related to protocols and their overrides
Projects
None yet
Development

No branches or pull requests

2 participants