Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EoS workchain: return results also when calculation at some volumes fail #281

Open
bosonie opened this issue Mar 30, 2022 · 0 comments
Open

Comments

@bosonie
Copy link
Collaborator

bosonie commented Mar 30, 2022

In the current implementation of the EoS workchain, if any of the calculated volumes fails, the workchain finishes with error "ERROR_SUB_PROCESS_FAILED" and no output is returned in the workchain.
This is inconvenient since it might happen that few out of many calculated volumes fail and not having outputs makes more difficult to retrieve info on the calculations completed successfully.
On the other hand, it is also incorrect to return exit status zero when one calculation did not finish.
An option could be to return the energy and volume of all the successful calculations AND return an error if any of the calculations failed.
Another option could be to define a rate of success that is acceptable, and take action based on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant