Bump mypy to 1.16.0

Author: danielhollas

pyproject.toml

@@ -229,7 +229,7 @@ notebook = [
 ]
 pre-commit = [
   'aiida-core[atomic_tools,rest,tests,tui]',
-  'mypy~=1.13.0',
+  'mypy~=1.16.0',
   'packaging~=23.0',
   'pre-commit~=3.5',
   'sqlalchemy[mypy]~=2.0',

src/aiida/cmdline/commands/cmd_profile.py

@@ -122,17 +122,17 @@ def profile_setup():
     """Set up a new profile."""
 
 
-@verdi_profile.command('configure-rabbitmq')  # type: ignore[arg-type]
+@verdi_profile.command('configure-rabbitmq')
+@click.pass_context
 @arguments.PROFILE(default=defaults.get_default_profile)
 @options.FORCE()
+@options.NON_INTERACTIVE(default=True, show_default='--non-interactive')
 @setup.SETUP_BROKER_PROTOCOL()
 @setup.SETUP_BROKER_USERNAME()
 @setup.SETUP_BROKER_PASSWORD()
 @setup.SETUP_BROKER_HOST()
 @setup.SETUP_BROKER_PORT()
 @setup.SETUP_BROKER_VIRTUAL_HOST()
-@options.NON_INTERACTIVE(default=True, show_default='--non-interactive')
-@click.pass_context
 def profile_configure_rabbitmq(ctx, profile, non_interactive, force, **kwargs):
     """Configure RabbitMQ for a profile.
 

src/aiida/engine/processes/functions.py

@@ -355,11 +355,11 @@ def build(func: FunctionType, node_class: t.Type['ProcessNode']) -> t.Type['Func
         """
         if (
             not issubclass(node_class, ProcessNode)  # type: ignore[redundant-expr]
-            or not issubclass(node_class, FunctionCalculationMixin)  # type: ignore[unreachable]
+            or not issubclass(node_class, FunctionCalculationMixin)
         ):
             raise TypeError('the node_class should be a sub class of `ProcessNode` and `FunctionCalculationMixin`')
 
-        signature = inspect.signature(func)  # type: ignore[unreachable]
+        signature = inspect.signature(func)
 
         args: list[str] = []
         var_positional: str | None = None
@@ -373,17 +373,21 @@ def build(func: FunctionType, node_class: t.Type['ProcessNode']) -> t.Type['Func
             LOGGER.warning(f'function `{func.__name__}` has invalid type hints: {exception}')
             annotations = {}
 
-        try:
-            parsed_docstring = docstring_parser.parse(func.__doc__)
-        except Exception as exception:
-            LOGGER.warning(f'function `{func.__name__}` has a docstring that could not be parsed: {exception}')
-            param_help_string = {}
+        if func.__doc__ is None:
+            param_help_string: dict[str, str | None] = {}
             namespace_help_string = None
         else:
-            param_help_string = {param.arg_name: param.description for param in parsed_docstring.params}
-            namespace_help_string = parsed_docstring.short_description if parsed_docstring.short_description else ''
-            if parsed_docstring.long_description is not None:
-                namespace_help_string += f'\n\n{parsed_docstring.long_description}'
+            try:
+                parsed_docstring = docstring_parser.parse(func.__doc__)
+            except Exception as exception:
+                LOGGER.warning(f'function `{func.__name__}` has a docstring that could not be parsed: {exception}')
+                param_help_string = {}
+                namespace_help_string = None
+            else:
+                param_help_string = {param.arg_name: param.description for param in parsed_docstring.params}
+                namespace_help_string = parsed_docstring.short_description if parsed_docstring.short_description else ''
+                if parsed_docstring.long_description is not None:
+                    namespace_help_string += f'\n\n{parsed_docstring.long_description}'
 
         for key, parameter in signature.parameters.items():
             if parameter.kind in [parameter.POSITIONAL_ONLY, parameter.POSITIONAL_OR_KEYWORD, parameter.KEYWORD_ONLY]:
@@ -435,7 +439,7 @@ def define(cls, spec):
                     def indirect_default(value=default):
                         return to_aiida_type(value)
                 else:
-                    indirect_default = default
+                    indirect_default = default  # type: ignore[assignment]
 
                 spec.input(
                     parameter.name,

src/aiida/engine/processes/process.py

@@ -80,7 +80,7 @@ class Process(PlumpyProcess):
     class SaveKeys(enum.Enum):
         """Keys used to identify things in the saved instance state bundle."""
 
-        CALC_ID: str = 'calc_id'
+        CALC_ID = 'calc_id'
 
     @classmethod
     def spec(cls) -> ProcessSpec:

src/aiida/orm/nodes/data/code/installed.py

@@ -159,7 +159,7 @@ def get_executable(self) -> pathlib.PurePath:
         """
         return self.filepath_executable
 
-    @property  # type: ignore[override]
+    @property
     def computer(self) -> Computer:
         """Return the computer of this code."""
         assert self.backend_entity.computer is not None

src/aiida/orm/nodes/process/calculation/calcfunction.py

@@ -47,7 +47,7 @@ def validate_outgoing(self, target: 'Node', link_type: LinkType, link_label: str
             )
 
 
-class CalcFunctionNode(FunctionCalculationMixin, CalculationNode):  # type: ignore[misc]
+class CalcFunctionNode(FunctionCalculationMixin, CalculationNode):
     """ORM class for all nodes representing the execution of a calcfunction."""
 
     _CLS_NODE_LINKS = CalcFunctionNodeLinks

src/aiida/orm/nodes/process/workflow/workfunction.py

@@ -45,7 +45,7 @@ def validate_outgoing(self, target: 'Node', link_type: LinkType, link_label: str
             )
 
 
-class WorkFunctionNode(FunctionCalculationMixin, WorkflowNode):  # type: ignore[misc]
+class WorkFunctionNode(FunctionCalculationMixin, WorkflowNode):
     """ORM class for all nodes representing the execution of a workfunction."""
 
     _CLS_NODE_LINKS = WorkFunctionNodeLinks

src/aiida/repository/backend/abstract.py

@@ -75,10 +75,7 @@ def put_object_from_filelike(self, handle: BinaryIO) -> str:
         :return: the generated fully qualified identifier for the object within the repository.
         :raises TypeError: if the handle is not a byte stream.
         """
-        if (
-            not isinstance(handle, io.BufferedIOBase)  # type: ignore[redundant-expr,unreachable]
-            and not self.is_readable_byte_stream(handle)
-        ):
+        if not isinstance(handle, io.BufferedIOBase) and not self.is_readable_byte_stream(handle):
             raise TypeError(f'handle does not seem to be a byte stream: {type(handle)}.')
         return self._put_object_from_filelike(handle)