Reintroduces

Embeds the docker-compose offered by firecrest-v2 into CI to run
with real firecrest server.

Open questions:
- [ ] Should we keep the mock? Then we need to run it in the CI and
  maintain it but maybe helpful for finding bugs. Then I would keept the
  workflow files
- [ ] Fix v2 endpoint problems

Author: agoscinski

.firecrest-demo-config.json

@@ -1,8 +1,8 @@
  {
-    "url": "",
-    "token_uri": "",
-    "client_id": "",
-    "client_secret": "",
+    "url": "http://localhost:8000/",
+    "token_uri": "http://localhost:8080/auth/realms/kcrealm/protocol/openid-connect/token",
+    "client_id": "firecrest-test-client",
+    "client_secret": "wZVHVIEd9dkJDh9hMKc6DTvkqXxnDttk",
     "compute_resource": "",
     "temp_directory": "",
     "small_file_size_mb": 5.0,

.github/workflows/server-tests.yml

@@ -39,23 +39,37 @@ jobs:
     steps:
     - uses: actions/checkout@v4
 
+    - name: Checkout firecrest-v2 Docker resources
+      uses: actions/checkout@v4
+      with:
+        repository: eth-cscs/firecrest-v2
+        ref: 2.2.6
+        path: firecrest-v2
+
+    - name: Docker compose
+      run: |
+        docker compose -f firecrest-v2/docker-compose.yml up -d
+
     - name: Set up Python ${{ matrix.python-version }}
       uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
         cache: 'pip'
+
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
         pip install -e .[dev]
+
     - name: Test with pytest
-      run: pytest -vv  --cov=aiida_firecrest --cov-report=xml --cov-report=term
+      run: |
+        pytest --ignore=firecrest-v2 --firecrest-config .firecrest-demo-config.json -vv  --cov=aiida_firecrest --cov-report=xml --cov-report=term
 
     - name: Upload coverage reports to Codecov
       uses: codecov/codecov-action@v4
       with:
         name: aiida-firecrest-pytests
-        flags: pytests
+        flags: pytests --.....
         file: ./coverage.xml
         fail_ci_if_error: true
         token: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/tests.yml

@@ -26,7 +26,7 @@ requires-python = ">=3.9"
 dependencies = [
     "aiida-core@git+https://github.com/aiidateam/aiida-core.git@954cbdd",
     "click",
-    "pyfirecrest@git+https://github.com/eth-cscs/pyfirecrest.git@6cae414",
+    "pyfirecrest~=3.1.0",
     "pyyaml",
 ]
 

pyproject.toml

@@ -495,7 +495,7 @@ def firecrest_config(
             firecrest_url=config.url,
             authorization=firecrest.ClientCredentialsAuth(
                 config.client_id,
-                Path(config.client_secret).read_text().strip(),
+                config.client_secret,
                 config.token_uri,
             ),
         )