-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Labels
improvementImproving already existing featuresImproving already existing features
Description
To avoid the current bash escaping that adds single quotes around every command and argument, I added a bit of hacky sed
logic:
aiida-hyperqueue/aiida_hyperqueue/scheduler.py
Lines 150 to 153 in 3f38f17
submit_command = ( | |
f"chmod 774 {submit_script}; options=$(grep '#HQ' {submit_script});" | |
f"sed -i s/\\'srun\\'/srun\ --cpu-bind=map_cpu:\$HQ_CPUS/ {submit_script};" | |
f'hq submit ${{options:3}} ./{submit_script}') |
If/when it's possible to avoid the single quotes around all items in the srun
line, we can e.g. simply add this to the srun
command of the computer setup.
However, we should probably not add this option at all when running on multiple nodes. I haven't tested this so far.
Metadata
Metadata
Assignees
Labels
improvementImproving already existing featuresImproving already existing features