Necessary issues to resolve

[Andrew-Chen-Wang]

EDIT I am in the process of moving aioredis to redis-py at RedisLabs. Apologies for the wait.

---

Several issues will be resolved by #1156 which will probably be included in 2.1.0. Issues to be resolved with potential fixes:

• Warning caused by Redis.__del__() #1115
  • Just delete the __del__ magic method and get everyone to manually disconnect.
  • Fixed in Remove __del__ from Redis (Fixes #1115) #1227
• Pubsub: health check races with get_message to read from the socket #1217
  • The fix should be included once the parallel PR in redis-py is merged
  • Fixed in Fix health check after unsubscribe #1207
• [2.0] Should Lock default to using contextvars? #1040
  • Potentially can be resolved via the solution used at aredis
• aioredis 1.3.1 vs 2.0.0 performance #1208
  • Looking for a fix by @m-novikov. Any help at [RFC] Use callback based asyncio.Protocol for communication #1216 would be super appreciated!
• ConnectionResetError: [Errno 104] Connection reset by peer #778 (comment)
  • Fixed by ConnectionResetError: [Errno 104] Connection reset by peer #778 (comment)
  • Fixed by Redis update 2021-10-08 #1156 Retry class and get_connection: catch OSError too redis/redis-py#1832

Wishlist (not necessary to get into 2.0.1):

• Sentinel client ConnectionError "Too many connections" #1173
• RuntimeError: coroutine ignored GeneratorExit #1137
  • Resolved by using Hiredis
  • We should put something in the docs saying "INSTALL HIREDIS (RECOMMENDED)"
• Redis.close() doesn't close connection pool created in __init__ #1103
  • I'd like to know if this is still an issue.
  • To be fixed in Add auto_close_connection_pool and close_connection_pool in Redis.close() #1256 . The issue is that redis-py has auto cleanup code in __del__ but aioredis doesn't have the implicit capability since there is no async del method.

[Andrew-Chen-Wang]

Current plan for the port of #1156 as that is probably never going to merge. If anyone would like to help, please ping me in this thread:

• New winter semester is starting, so I'll be fairly busy.
• We should first reorganize our code to be similar in structure to redis-py. The issue now with Redis update 2021-10-08 #1156 is that it's not inline with current master. Incremental changes i.e. porting code from redis-py can be done much faster if we first do the reorganization
• Incremental PRs. We don't need to do a PR for each PR done in redis-py, but the port is humongous, so putting a few features in at a time reduces the burden.

Edit 2022-01-03: should be up to date with redis-py 4.0.1 now. Hoping to push it out in 2.1.0

[Andrew-Chen-Wang]

I am moving aioredis to redis-py now.