Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument validation should be moved out from the argument parsers #37

Open
akamsteeg opened this issue Jun 9, 2018 · 2 comments
Open

Argument validation should be moved out from the argument parsers #37

akamsteeg opened this issue Jun 9, 2018 · 2 comments
Labels
enhancement

Comments

@akamsteeg
Copy link
Owner

Currently, it's the task of the ICommandLineArgumentsParser implementations to validate the arguments using the supplied ArgumentValidator instances. Since this is the same for all parsers (and it's hard to get right) we should move it out to the call site.
@akamsteeg akamsteeg added this to the 3.0.0 milestone Jun 9, 2018
@akamsteeg
Copy link
Owner Author

Hm, we might be able to shoehorn in a system for parse errors too. Now we silently disregard those, but that's not ideal.

@akamsteeg akamsteeg removed this from the 3.0.0 milestone Sep 18, 2019
@akamsteeg
Copy link
Owner Author

This is actually quite hard to do, so I'm moving this to "somewhere in the future".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akamsteeg