Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one whitelist IP can be defined via the .env file #57

Closed
carlos-reynosa opened this issue Oct 12, 2022 · 0 comments
Closed

Only one whitelist IP can be defined via the .env file #57

carlos-reynosa opened this issue Oct 12, 2022 · 0 comments

Comments

@carlos-reynosa
Copy link

carlos-reynosa commented Oct 12, 2022

This only allows 1 IP to be defined within the .env file.

Getting the environment value grabs a whole string:

'whitelist' => [env('FIREWALL_WHITELIST', '')],

When it's used it is only treated as containing 1 IP in a string:

return IpUtils::checkIp($this->ip(), config('firewall.whitelist'));

@carlos-reynosa carlos-reynosa changed the title Only 1 IP can be defined via the .env file Only one whitelist IP can be defined via the .env file Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant