Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Boolean Functionality To Filter Operation (in yaml schema definition) #366

Closed
Ochibobo opened this issue Feb 5, 2021 · 1 comment
Closed

Comments

@Ochibobo
Copy link

Ochibobo commented Feb 5, 2021

I've been working with the Aleph Schema on yaml files with ftm(cli) in the past month and I think it's fit if you add boolean functionality (if not present) to the Filter operation and allow it to span mutliple columns.

Currently, I've seen that among the supported operations are:

filter and filter_not

And apparently, they work for single columns. Listing multiple columns has no effect on all columns listed after the first one (correct me if I'm wrong).

The proposed functionality will have something like this:

  filter_and:
    columnA: "FilterClauseA"
    columnB: "FilterClauseB"

This filters each row entry based on the stated criteria from columnA, columnB, columnC,......, columnN. Returned rows must meet all stated criteria per column. Just like an AND operation.

  filter_or:
    columnA: "FilterClauseA"
    columnB: "FilterClauseB"

This filters each row entry based on the stated criteria from columnA, columnB, columnC,......, columnN. Returned rows should meet at least one stated criteria per column. Just like an OR operation.

IMO, the schema definition on yaml files (like a DSL) is one of the interesting features in FtM/Aleph. I don't know if the proposed features exist, if not, it seems fit for them to be added to improve the DSL's flexibility and reduce dependency on writing extra code.

@Ochibobo
Copy link
Author

Given that this issue is being handled by #373, I'm going to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant