Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: is pitch-detection real-time-safe? #24

Open
magnetophon opened this issue Sep 6, 2022 · 1 comment
Open

Question: is pitch-detection real-time-safe? #24

magnetophon opened this issue Sep 6, 2022 · 1 comment

Comments

@magnetophon
Copy link

magnetophon commented Sep 6, 2022

I was chatting over at the rust audio discord, and got told that get_pitch of the McLeodDetector might not be rt-safe.
In particular this line was pointed out to me by @WeirdConstructor.

Is your goal for pitch-detection to be real time safe?

@magnetophon
Copy link
Author

magnetophon commented Sep 11, 2022

With a lot of help from the Rust Audio discord, I managed to move all allocation to new() in my fork.

It is very hacky at the moment:

  • made by a rust noob (me!)
  • needs cleanup
  • broken tests
  • broken benchmarks
  • no documentation

If you want, I can work on the above issues and do a PR.
I'll need some guidance though, as I've just begun learning rust!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant