Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mTLS options show diff in argocd #501

Open
yujunz opened this issue Sep 11, 2023 · 3 comments
Open

mTLS options show diff in argocd #501

yujunz opened this issue Sep 11, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@yujunz
Copy link
Contributor

yujunz commented Sep 11, 2023

It seems the operator will marshal the values to full representation of the duration. It causes diff in argocd. I would expect it keep the value as input and convert internally if needed.

Screenshot 2023-09-11 at 09 45 25

The current workaround is manually convert the duration to full format on input.

@alexandrevilain alexandrevilain added the bug Something isn't working label Sep 11, 2023
@alexandrevilain
Copy link
Owner

Seems there is no easy solution we can do on the operator side ...
Did you checked argoproj/argo-cd#14229 ?

@ElanHasson
Copy link
Contributor

I ran into this. Just set the values in your yaml to match what it gets changed to. argo just trims the unnecessary values.

@bmorton
Copy link
Contributor

bmorton commented Nov 22, 2024

I ran into this as well and set the values to match as @ElanHasson did. That ArgoCD issue that you linked works for me as well if I add this:

spec:
  syncOptions:
    - RespectIgnoreDifferences=true
  ignoreDifferences:
    - group: temporal.io
      kind: TemporalCluster
      jsonPointers:
        - /spec/mTLS/certificatesDuration
        - /spec/mTLS/renewBefore

Can we close this out if we document these caveats for ArgoCD somewhere? I'm happy to contribute a doc page on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants