From ee4cbb7ffea4394fef4367cc02782657a0e94c16 Mon Sep 17 00:00:00 2001 From: James Lamb Date: Thu, 30 May 2024 11:29:00 -0500 Subject: [PATCH] remove unnecessary 'setuptools' and 'wheel' dependencies (#4448) Contributes to https://github.com/rapidsai/build-planning/issues/62. It looks like the `cugraph` and `pylibcugraph` wheels and conda recipes have unnecessary dependencies on `setuptools` and `wheel`. I suspect those are left over from before those libraries were cut over to `scikit-build-core`. This proposes removing those. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Jake Awe (https://github.com/AyodeAwe) - Rick Ratzel (https://github.com/rlratzel) URL: https://github.com/rapidsai/cugraph/pull/4448 --- conda/recipes/cugraph/meta.yaml | 1 - conda/recipes/pylibcugraph/meta.yaml | 1 - dependencies.yaml | 2 -- python/cugraph/pyproject.toml | 2 -- python/pylibcugraph/pyproject.toml | 2 -- 5 files changed, 8 deletions(-) diff --git a/conda/recipes/cugraph/meta.yaml b/conda/recipes/cugraph/meta.yaml index b66e43e16a3..cfa9d80b993 100644 --- a/conda/recipes/cugraph/meta.yaml +++ b/conda/recipes/cugraph/meta.yaml @@ -69,7 +69,6 @@ requirements: - raft-dask ={{ minor_version }} - rmm ={{ minor_version }} - scikit-build-core >=0.7.0 - - setuptools run: - aiohttp - {{ pin_compatible('cuda-version', max_pin='x', min_pin='x') }} diff --git a/conda/recipes/pylibcugraph/meta.yaml b/conda/recipes/pylibcugraph/meta.yaml index 314d8c7ea8b..67df77f5ce6 100644 --- a/conda/recipes/pylibcugraph/meta.yaml +++ b/conda/recipes/pylibcugraph/meta.yaml @@ -66,7 +66,6 @@ requirements: - pylibraft ={{ minor_version }} - python - scikit-build-core >=0.7.0 - - setuptools run: - {{ pin_compatible('cuda-version', max_pin='x', min_pin='x') }} {% if cuda_major == "11" %} diff --git a/dependencies.yaml b/dependencies.yaml index e3ff5a4c92c..02823ce5d3d 100644 --- a/dependencies.yaml +++ b/dependencies.yaml @@ -71,7 +71,6 @@ files: table: build-system includes: - common_build - - python_build_wheel - depends_on_rmm - depends_on_pylibraft - depends_on_pylibcugraph @@ -105,7 +104,6 @@ files: table: build-system includes: - common_build - - python_build_wheel - depends_on_rmm - depends_on_pylibraft - python_build_cythonize diff --git a/python/cugraph/pyproject.toml b/python/cugraph/pyproject.toml index 9d222705541..4c42e289e58 100644 --- a/python/cugraph/pyproject.toml +++ b/python/cugraph/pyproject.toml @@ -10,8 +10,6 @@ requires = [ "pylibraft==24.8.*", "rmm==24.8.*", "scikit-build-core[pyproject]>=0.7.0", - "setuptools>=61.0.0", - "wheel", ] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`. build-backend = "scikit_build_core.build" diff --git a/python/pylibcugraph/pyproject.toml b/python/pylibcugraph/pyproject.toml index 9377d46dee0..fdb82244e37 100644 --- a/python/pylibcugraph/pyproject.toml +++ b/python/pylibcugraph/pyproject.toml @@ -9,8 +9,6 @@ requires = [ "pylibraft==24.8.*", "rmm==24.8.*", "scikit-build-core[pyproject]>=0.7.0", - "setuptools>=61.0.0", - "wheel", ] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`. build-backend = "scikit_build_core.build"