linting

Author: alexcasalboni

cdk/typescript/jest.config.js

@@ -1,7 +1,8 @@
+'use strict';
 module.exports = {
-  roots: ['<rootDir>/test'],
-  testMatch: ['**/*.test.ts'],
-  transform: {
-    '^.+\\.tsx?$': 'ts-jest'
-  }
+    roots: ['<rootDir>/test'],
+    testMatch: ['**/*.test.ts'],
+    transform: {
+        '^.+\\.tsx?$': 'ts-jest',
+    },
 };

lambda/analyzer.js

@@ -27,7 +27,7 @@ module.exports.handler = async(event, context) => {
 
     const result = findOptimalConfiguration(event);
 
-    if (!!event.includeOutputResults) {
+    if (event.includeOutputResults) {
         // add stats to final result
         result.stats = event.stats.map(stat => ({
             value: stat.value,

lambda/cleaner.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { ResourceNotFoundException } = require("@aws-sdk/client-lambda");
+const { ResourceNotFoundException } = require('@aws-sdk/client-lambda');
 const utils = require('./utils');
 
 /**

lambda/utils.js

@@ -1,7 +1,7 @@
 'use strict';
 
-const { CreateAliasCommand, DeleteAliasCommand, DeleteFunctionCommand, GetAliasCommand, GetFunctionConfigurationCommand, InvokeCommand, LambdaClient, PublishVersionCommand, UpdateAliasCommand, UpdateFunctionConfigurationCommand, waitUntilFunctionActive, waitUntilFunctionUpdated, ResourceNotFoundException } = require("@aws-sdk/client-lambda");
-const { GetObjectCommand, S3Client } = require("@aws-sdk/client-s3");
+const { CreateAliasCommand, DeleteAliasCommand, DeleteFunctionCommand, GetAliasCommand, GetFunctionConfigurationCommand, InvokeCommand, LambdaClient, PublishVersionCommand, UpdateAliasCommand, UpdateFunctionConfigurationCommand, waitUntilFunctionActive, waitUntilFunctionUpdated, ResourceNotFoundException } = require('@aws-sdk/client-lambda');
+const { GetObjectCommand, S3Client } = require('@aws-sdk/client-s3');
 const url = require('url');
 
 
@@ -56,7 +56,7 @@ module.exports.verifyAliasExistance = async(lambdaARN, alias) => {
         await utils.getLambdaAlias(lambdaARN, alias);
         return true;
     } catch (error) {
-        console.log("Error during verifyAlias (probably OK!)")
+        console.log('Error during verifyAlias (probably OK!)');
         if (error instanceof ResourceNotFoundException) {
             // OK, the alias isn't supposed to exist
             console.log('OK, even if missing alias ');
@@ -245,7 +245,7 @@ module.exports.deleteLambdaAlias = (lambdaARN, alias) => {
         Name: alias,
     };
     const lambda = utils.lambdaClientFromARN(lambdaARN);
-    return lambda.send( new DeleteAliasCommand(params));
+    return lambda.send(new DeleteAliasCommand(params));
 };
 
 /**
@@ -366,13 +366,12 @@ module.exports._fetchS3Object = async(bucket, key) => {
             Bucket: bucket,
             Key: key,
         };
-        var response = undefined;
-        response = await s3Client.send(new GetObjectCommand(input));
+        var response = await s3Client.send(new GetObjectCommand(input));
         return await response.Body.transformToString('utf-8');
     } catch (err) {
-        var statusCode = err.statusCode
+        var statusCode = err.statusCode;
         if (err.$response && err.$response.statusCode) {
-            statusCode = err.$response.statusCode
+            statusCode = err.$response.statusCode;
         }
         if (statusCode === 403) {
             throw new Error(
@@ -566,12 +565,12 @@ module.exports.extractDurationFromText = (log) => {
 module.exports.extractDurationFromJSON = (log) => {
     // extract each line and parse it to JSON object
     const lines = log.split('\n').filter((line) => line.startsWith('{')).map((line) => {
-         try {
-              return JSON.parse(line);
-         } catch (e) {
+        try {
+            return JSON.parse(line);
+        } catch (e) {
             console.error(`Detected invalid JSON line: ${line}`);
-             return '';
-       }
+            return '';
+        }
     });
     // find the log corresponding to the invocation report
     const durationLine = lines.find((line) => line.type === 'platform.report');
@@ -610,8 +609,8 @@ module.exports.lambdaClientFromARN = (lambdaARN) => {
     const region = this.regionFromARN(lambdaARN);
     return new LambdaClient({
         region,
-        requestTimeout: 15 * 60 * 1000
-    })
+        requestTimeout: 15 * 60 * 1000,
+    });
 };
 
 /**

package-lock.json

@@ -21,8 +21,6 @@
   ],
   "licence": "Apache",
   "scripts": {
-    "deploy": "bash deploy.sh",
-    "execute": "bash execute.sh",
     "lint": "eslint --ignore-path .gitignore .",
     "test": "mocha",
     "coverage": "c8 --reporter=lcov --reporter=cobertura --reporter=text-summary mocha"

package.json

@@ -4,7 +4,7 @@ const sinon = require('sinon');
 const expect = require('expect.js');
 
 var awsV3Mock = require('aws-sdk-client-mock');
-const { CreateAliasCommand, DeleteAliasCommand, DeleteFunctionCommand, GetAliasCommand, InvokeCommand, LambdaClient, PublishVersionCommand, UpdateAliasCommand, UpdateFunctionConfigurationCommand, ResourceNotFoundException } = require("@aws-sdk/client-lambda");
+const { CreateAliasCommand, DeleteAliasCommand, DeleteFunctionCommand, GetAliasCommand, InvokeCommand, LambdaClient, PublishVersionCommand, UpdateAliasCommand, UpdateFunctionConfigurationCommand, ResourceNotFoundException } = require('@aws-sdk/client-lambda');
 
 const utils = require('../../lambda/utils');
 
@@ -1687,7 +1687,7 @@ describe('Lambda Functions', async() => {
             expect(result.stats).to.eql(event.stats.map(stat => ({
                 value: stat.value,
                 averagePrice: stat.averagePrice,
-                averageDuration: stat.averageDuration
+                averageDuration: stat.averageDuration,
             })));
 
             expect(result.stats[0]).to.not.have.property('totalCost');