-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart History Futures #250
Comments
I agree - without support for this, its quite difficult to get data for futures (historical). What makes this specific "service" different from the others is that it uses a "GET" command rather than "SUBS" or "ADD". Likewise, it only accepts a single symbol at a time unlike the rest. I believe this is why it got left out - as the current implementation makes the assumption that they all have the same interface - thus the _service_op method requires some modification to handle this "special case". I too have written my own implementation and can share it if needed. Thanks! I believe a clean API for this would be one which would return any historical data requested as per the frequency and period parameters, followed by a callback to the existing "CHART_FUTURES" for the same symbol, which would yield an active websocket with live data AFTER all the historical data has been sent to the client. |
@plucena24 To the extent that your implementation could be packaged as a pull request, would you be up for doing so? |
Gross hack below if anyone is interested... it's fragile and any changes to how deferred message objects are defined will blow this up. Also, not sure how this code will behave if someone is exercising other pieces of the code - I was only interested in the historical data. I see why this hasn't been implemented yet. Hoping that @plucena24 will drop the sweet codes.
|
The streaming object has a Chart History Future is needed to get futures history. Can that be added?
If not I will add.
The text was updated successfully, but these errors were encountered: