Skip to content

Commit 3cf6469

Browse files
committed
Add more node versions in front building github action
1 parent a620c3e commit 3cf6469

File tree

2 files changed

+21
-14
lines changed

2 files changed

+21
-14
lines changed

.github/workflows/build_front.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,23 @@ on:
1111
jobs:
1212
build:
1313
name: Build front-end
14-
runs-on: ubuntu-latest
14+
runs-on: ${{ matrix.os }}
15+
strategy:
16+
matrix:
17+
include:
18+
- os: ubuntu-latest
19+
node_version: "14"
20+
- os: ubuntu-latest
21+
node_version: "16"
22+
- os: ubuntu-latest
23+
node_version: "18"
1524
steps:
1625
- uses: actions/checkout@v3
1726

18-
- name: Set Node.js 16.x
27+
- name: Set up Node.js
1928
uses: actions/setup-node@v3
2029
with:
21-
node-version: 16.x
30+
node-version: ${{ matrix.node_version }}
2231

2332
- name: Run install
2433
uses: borales/actions-yarn@v4

web/src/views/surface/index.tsx

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,13 @@ const stateFromUrl = (): SurfaceViewState => {
8282
};
8383
}
8484

85-
return (urlState as unknown) as SurfaceViewState;
85+
return urlState as unknown as SurfaceViewState;
8686
};
8787

8888
// Custom hook to load state from URL
8989
const useSurfaceState = (): [
9090
SurfaceViewState,
91-
React.Dispatch<React.SetStateAction<SurfaceViewState>>
91+
React.Dispatch<React.SetStateAction<SurfaceViewState>>,
9292
] => {
9393
const urlState = stateFromUrl();
9494

@@ -126,7 +126,7 @@ const SurfaceExplorer = ({ datasetId }: SurfaceViewProps) => {
126126
const [meshTypeLabels, setMeshTypeLabels] = useState<string[]>([]);
127127
const [hemiLabels, setHemiLabels] = useState<string[]>([]);
128128
const [unit, setUnit] = useState<string | undefined>(undefined);
129-
const [datasetDescriptions, setDatasetDescriptions] = useState<any>({});
129+
const [datasetDescriptions] = useState<any>({});
130130

131131
// Load state from url
132132
const [state, setState] = useSurfaceState();
@@ -199,7 +199,7 @@ const SurfaceExplorer = ({ datasetId }: SurfaceViewProps) => {
199199
hemiLabels?.length > 0
200200
) {
201201
if (Object.keys(state.panes).length === 0) {
202-
setState(({
202+
setState({
203203
...state,
204204
panes: {
205205
[nanoid(4)]: defaultPaneState(
@@ -210,7 +210,7 @@ const SurfaceExplorer = ({ datasetId }: SurfaceViewProps) => {
210210
hemiLabels
211211
),
212212
},
213-
} as unknown) as SurfaceViewState);
213+
} as unknown as SurfaceViewState);
214214
}
215215
}
216216
}, [
@@ -419,15 +419,13 @@ const SurfaceExplorer = ({ datasetId }: SurfaceViewProps) => {
419419
const paneSubjects = Object.keys(state.panes).map(
420420
(k) => state.panes[k].subject
421421
);
422-
const previousPaneSubjects = usePrevious<(number | undefined)[]>(
423-
paneSubjects
424-
);
422+
const previousPaneSubjects =
423+
usePrevious<(number | undefined)[]>(paneSubjects);
425424
const paneMeanSurfaceMaps = Object.keys(state.panes).map(
426425
(k) => state.panes[k].meanSurfaceMap
427426
);
428-
const previousPaneMeanSurfaceMaps = usePrevious<(boolean | undefined)[]>(
429-
paneMeanSurfaceMaps
430-
);
427+
const previousPaneMeanSurfaceMaps =
428+
usePrevious<(boolean | undefined)[]>(paneMeanSurfaceMaps);
431429

432430
useEffect(() => {
433431
if (

0 commit comments

Comments
 (0)