Skip to content

Commit bf49dde

Browse files
Sam Davis Omekara (from Dev Box)chromium-wpt-export-bot
Sam Davis Omekara (from Dev Box)
authored andcommitted
[Gap Decorations]: Introduce ColumnRuleStyle on ComputedStyle
This CL introduces a new data structure to extend the ColumnRuleStyle property for the gap decorations feature. Previously, the `column-rule-style` property could hold only a single style value. However, with the gap decorations feature, this property can now hold multiple values. The CL utilizes the `GapDataList` template data structure to store these values in the computed style object. Additionally, sites that expect a single style value have been updated to call `GetLegacyValue()`, which returns the single style. The code is exercised through the gap-decorations-style-computed.html test. Bug: 357648037 Change-Id: Ic2da56eb1811a4d1f15ee54594aab3052696b774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6065161 Reviewed-by: Alison Maher <[email protected]> Commit-Queue: Sam Davis Omekara <[email protected]> Reviewed-by: Kurt Catti-Schmidt <[email protected]> Reviewed-by: Kevin Babbitt <[email protected]> Cr-Commit-Position: refs/heads/main@{#1391995}
1 parent d54d933 commit bf49dde

File tree

1 file changed

+30
-0
lines changed

1 file changed

+30
-0
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
<!DOCTYPE html>
2+
<html>
3+
<head>
4+
<meta charset="utf-8">
5+
<title>CSS Gap Decoration: column-rule-style getComputedStyle()</title>
6+
<link rel="help" href="https://kbabbitt.github.io/css-gap-decorations/pr-11115/Overview.html#column-row-rule-style">
7+
<link rel="author" title="Sam Davis Omekara Jr." href="mailto:[email protected]">
8+
<meta name="assert" content="column-rule-style computed value is as specified.">
9+
<script src="/resources/testharness.js"></script>
10+
<script src="/resources/testharnessreport.js"></script>
11+
<script src="/css/support/computed-testcommon.js"></script>
12+
</head>
13+
<body>
14+
<div id="target"></div>
15+
<script>
16+
test_computed_value("column-rule-style", "none");
17+
test_computed_value("column-rule-style", "hidden");
18+
test_computed_value("column-rule-style", "dotted");
19+
test_computed_value("column-rule-style", "dashed");
20+
test_computed_value("column-rule-style", "solid");
21+
test_computed_value("column-rule-style", "double");
22+
test_computed_value("column-rule-style", "groove");
23+
test_computed_value("column-rule-style", "ridge");
24+
test_computed_value("column-rule-style", "inset");
25+
26+
// TODO(crbug.com/357648037): Add tests for multiple values when parsing is implemented.
27+
28+
</script>
29+
</body>
30+
</html>

0 commit comments

Comments
 (0)