Skip to content

AWS Location Service adapter does not store raw response in @data #1621

Open
@woodhull

Description

@woodhull

Expected behavior

While using AWS Location Service adapter, it should be possible to access the data property of responses using the data accessor.

Actual behavior

Geocoder::Result::AmazonLocationService stores the response in a @place variable while the base class expects the variable to be named @data

https://github.com/alexreisner/geocoder/blob/master/lib/geocoder/results/amazon_location_service.rb
vs
https://github.com/alexreisner/geocoder/blob/master/lib/geocoder/results/base.rb#L6

Steps to reproduce

Geocode results from AWS Location service are correct for the common attributes, but calling data always returns nil.

Environment info

  • Geocoder version:
  • Rails version:
  • Database (if applicable):
  • Lookup (if applicable):

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions