-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot create an auto-merge request when all requirements have already been passed #23
Comments
I'm not sure what the "correct" thing to do here should be. Options include:
To work around this in this repository, I ordered the approval task after the auto-merge one: https://github.com/alexwilson/enable-github-automerge-action/blob/main/.github/workflows/auto-merge-dependabot.yml |
I think it would be perfectly fine to document that the auto-merge should be one of the first steps in a workflow, and that it should definitely run before any automatic approval step. |
@alexwilson, it looks like this also happens if there are no required checks on a project. -- Financial-Times/origami-specialist-title-logos#66 |
Yeah, I'm not sure what we should do in that case @JakeChampion. Is using this library a fair enough intent that a user does want something to be merged, even with no checks? Perhaps a new configuration option would accommodate this? |
I personally would want the action by default to error out in the scenario where there are no required checks with a message which gives the different ways to stop it erroring out: |
When all PR requirements have already been met, it's not possible to enable auto-merge. Confusingly GitHub's API doesn't return an error message when this has happened.
The text was updated successfully, but these errors were encountered: