Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The parameter "amount" should instead be called something like "count" #121

Open
metov opened this issue Apr 3, 2020 · 1 comment
Open
Assignees
Labels
enhancement Small UI change or more optimized code
Milestone

Comments

@metov
Copy link

metov commented Apr 3, 2020

The endpoint /facts accepts a parameter amount which specifies the number of facts requested. However, "amount" technically refers to uncountable nouns, and hence implies that the value is a float: https://english.stackexchange.com/questions/9439/amount-vs-number-vs-quantity

Since the type is integer and in any case you cannot have half a fact, it would be more natural to call this something like count.

@alexwohlbruck
Copy link
Owner

You have a good point. I will look into changing this without breaking existing functionality

@alexwohlbruck alexwohlbruck self-assigned this Apr 4, 2020
@alexwohlbruck alexwohlbruck added the enhancement Small UI change or more optimized code label Apr 4, 2020
@alexwohlbruck alexwohlbruck added this to the Developer API milestone Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Small UI change or more optimized code
Projects
None yet
Development

No branches or pull requests

2 participants