Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't trigger release if a commit has happened since the "release" commit #667

Open
Haroenv opened this issue Feb 17, 2020 · 0 comments
Open

Comments

@Haroenv
Copy link
Contributor

Haroenv commented Feb 17, 2020

Describe the bug

When you prepare a release, but after merging you see something small is missing, I don't want to prepare the release again.

To Reproduce
Steps to reproduce the behavior:

  1. shipjs prepare
  2. git commit -m "something else"
  3. shipjs trigger

Expected behavior

The last prepare which was not yet released will now be released, but only if the changes since the last release chore, docs, maybe fix?

Screenshots

Skipping a release due to the following reason:
  > The commit message should have started with the following:
chore: release v1.4.0

Environment (please complete the following information):

  • environment: your local machine
  • Ship.js version: 0.13.1

Additional context

For now what I do is enable force pushing on the repo, making the fix in a separate commit, but reordering so the release commit is latest again, then disabling force push again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant