Skip to content

Commit ec65825

Browse files
authored
Merge pull request #2 from aliartiza75/add-nested-list-support
[add-nested-list-support] update listcompare.py file
2 parents 84dafc5 + 18c6bb7 commit ec65825

File tree

3 files changed

+31
-4
lines changed

3 files changed

+31
-4
lines changed

.github/workflows/python-app.yml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
# This workflow will install Python dependencies, run tests and lint with a single version of Python
2+
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions
3+
4+
name: Python application
5+
6+
on:
7+
push:
8+
branches: [ master ]
9+
pull_request:
10+
branches: [ master ]
11+
12+
jobs:
13+
build:
14+
15+
runs-on: ubuntu-latest
16+
17+
steps:
18+
- uses: actions/checkout@v2
19+
- name: Set up Python 3.8
20+
uses: actions/setup-python@v2
21+
with:
22+
python-version: 3.8
23+
- name: Install dependencies
24+
run: |
25+
python -m pip install --upgrade pip
26+
pip install flake8 pytest
27+
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
28+
- name: Lint with pycodestyle
29+
run: |
30+
pycodestyle listcompare/*.py

listcompare/listcompare.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,5 @@ def compare_list(list1, list2):
2020
for list2_item in list2:
2121
if list2_item not in list1:
2222
return False
23-
# check item of list1 exists in list2
24-
for list1_item in list1:
25-
if list1_item not in list2:
26-
return False
2723
return True
2824
raise Exception("Invalid Data provided")

requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
twine==1.13.0
22
cython==0.29.12
3+
pycodestyle==2.6.0
34

0 commit comments

Comments
 (0)