Skip to content

Commit 0eb0781

Browse files
authored
chore: ts lint (#2857)
* chore: ts lint * chore: ci workflows
1 parent 95032f1 commit 0eb0781

File tree

219 files changed

+367
-349
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

219 files changed

+367
-349
lines changed

.github/workflows/test.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,13 @@ name: Test CI
33
on: [push, pull_request]
44

55
jobs:
6+
lint:
7+
runs-on: ubuntu-latest
8+
steps:
9+
- uses: actions/checkout@v4
10+
- uses: pnpm/action-setup@v4
11+
- run: pnpm install
12+
- run: pnpm run tsc
613
test:
714
runs-on: ubuntu-latest
815

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@
3030
"pub:beta": "pnpm run build && pnpm -r --filter=./packages/* publish --tag beta",
3131
"preinstall": "npx only-allow pnpm",
3232
"prepare": "husky install",
33-
"commit": "git add -A && czg"
33+
"commit": "git add -A && czg",
34+
"tsc": "pnpm --filter=./packages/* tsc"
3435
},
3536
"devDependencies": {
3637
"@alifd/next": "^1.27.32",

packages/hooks/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@
2424
"scripts": {
2525
"build": "gulp && webpack-cli",
2626
"test": "vitest run --color",
27-
"test:cov": "vitest run --color --coverage"
27+
"test:cov": "vitest run --color --coverage",
28+
"tsc": "tsc --noEmit"
2829
},
2930
"files": [
3031
"dist",

packages/hooks/src/index.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import * as ahooks from '.';
33

44
describe('ahooks', () => {
55
test('exports modules should be defined', () => {
6-
Object.keys(ahooks).forEach((module) => {
7-
expect(ahooks[module]).toBeDefined();
6+
Object.entries(ahooks).forEach(([key, value]) => {
7+
expect(value).toBeDefined();
88
});
99
});
1010
});

packages/hooks/src/useAntdTable/__tests__/index.spec.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ describe('useAntdTable', () => {
5050
resetFields() {
5151
this.fieldsValue = { ...this.initialValue };
5252
},
53-
validateFields(fields) {
54-
const targetFields = {};
55-
fields.forEach((field) => {
56-
targetFields[field] = this.fieldsValue[field];
53+
validateFields(fields: any[]) {
54+
const targetFields: Record<string | number, any> = {};
55+
fields.forEach((field: string | number) => {
56+
targetFields[field] = (this.fieldsValue as any)[field];
5757
});
5858
return Promise.resolve(targetFields);
5959
},
@@ -185,10 +185,10 @@ describe('useAntdTable', () => {
185185
const v3Form = {
186186
...form,
187187
getInternalHooks: undefined,
188-
validateFields: function (fields, callback) {
189-
const targetFields = {};
190-
fields.forEach((field) => {
191-
targetFields[field] = this.fieldsValue[field];
188+
validateFields: function (fields: any[], callback: (arg0: undefined, arg1: {}) => void) {
189+
const targetFields: Record<string | number, any> = {};
190+
fields.forEach((field: string | number) => {
191+
targetFields[field] = (this.fieldsValue as any)[field];
192192
});
193193
callback(undefined, targetFields);
194194
},

packages/hooks/src/useAntdTable/demo/cache.tsx

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useState } from 'react';
1+
import { useState } from 'react';
22
import { Button, Col, Form, Input, Row, Table, Select } from 'antd';
33
import { useAntdTable, clearCache } from 'ahooks';
44
import ReactJson from 'react-json-view';
@@ -20,8 +20,20 @@ interface Result {
2020
}
2121

2222
const getTableData = (
23-
{ current, pageSize, sorter, filters, extra },
24-
formData: Object,
23+
{
24+
current,
25+
pageSize,
26+
sorter,
27+
filters,
28+
extra,
29+
}: {
30+
current: number;
31+
pageSize: number;
32+
sorter: any;
33+
filters: any;
34+
extra: any;
35+
},
36+
formData: Record<string, any>,
2537
): Promise<Result> => {
2638
console.log(sorter, filters, extra);
2739
let query = `page=${current}&size=${pageSize}`;

packages/hooks/src/useAntdTable/demo/form.tsx

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import React from 'react';
21
import { Button, Col, Form, Input, Row, Table, Select } from 'antd';
32
import { useAntdTable } from 'ahooks';
43
import ReactJson from 'react-json-view';
@@ -19,7 +18,16 @@ interface Result {
1918
list: Item[];
2019
}
2120

22-
const getTableData = ({ current, pageSize }, formData: Object): Promise<Result> => {
21+
const getTableData = (
22+
{
23+
current,
24+
pageSize,
25+
}: {
26+
current: number;
27+
pageSize: number;
28+
},
29+
formData: Object,
30+
): Promise<Result> => {
2331
let query = `page=${current}&size=${pageSize}`;
2432
Object.entries(formData).forEach(([key, value]) => {
2533
if (value) {

packages/hooks/src/useAntdTable/demo/init.tsx

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import React from 'react';
21
import { Button, Col, Form, Input, Row, Table, Select } from 'antd';
32
import { useAntdTable } from 'ahooks';
43
import ReactJson from 'react-json-view';
@@ -19,7 +18,16 @@ interface Result {
1918
list: Item[];
2019
}
2120

22-
const getTableData = ({ current, pageSize }, formData: Object): Promise<Result> => {
21+
const getTableData = (
22+
{
23+
current,
24+
pageSize,
25+
}: {
26+
current: number;
27+
pageSize: number;
28+
},
29+
formData: Object,
30+
): Promise<Result> => {
2331
let query = `page=${current}&size=${pageSize}`;
2432
Object.entries(formData).forEach(([key, value]) => {
2533
if (value) {
@@ -38,7 +46,7 @@ const getTableData = ({ current, pageSize }, formData: Object): Promise<Result>
3846
export default () => {
3947
const [form] = Form.useForm();
4048

41-
const { loading, tableProps, search, params } = useAntdTable(getTableData, {
49+
const { tableProps, search, params } = useAntdTable(getTableData, {
4250
form,
4351
defaultParams: [
4452
{ current: 2, pageSize: 5 },

packages/hooks/src/useAntdTable/demo/ready.tsx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useState } from 'react';
1+
import { useState } from 'react';
22
import { Button, Col, Form, Input, Row, Table, Select } from 'antd';
33
import { useAntdTable } from 'ahooks';
44
import ReactJson from 'react-json-view';
@@ -19,7 +19,16 @@ interface Result {
1919
list: Item[];
2020
}
2121

22-
const getTableData = ({ current, pageSize }, formData: Object): Promise<Result> => {
22+
const getTableData = (
23+
{
24+
current,
25+
pageSize,
26+
}: {
27+
current: number;
28+
pageSize: number;
29+
},
30+
formData: Object,
31+
): Promise<Result> => {
2332
let query = `page=${current}&size=${pageSize}`;
2433
Object.entries(formData).forEach(([key, value]) => {
2534
if (value) {

packages/hooks/src/useAntdTable/demo/table.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { Table } from 'antd';
2-
import React from 'react';
32
import { useAntdTable } from 'ahooks';
43

54
interface Item {
@@ -16,7 +15,13 @@ interface Result {
1615
list: Item[];
1716
}
1817

19-
const getTableData = ({ current, pageSize }): Promise<Result> => {
18+
const getTableData = ({
19+
current,
20+
pageSize,
21+
}: {
22+
current: number;
23+
pageSize: number;
24+
}): Promise<Result> => {
2025
const query = `page=${current}&size=${pageSize}`;
2126

2227
return fetch(`https://randomuser.me/api?results=55&${query}`)

0 commit comments

Comments
 (0)