Skip to content

Commit 030c153

Browse files
authored
Merge pull request #265 from allenai/gabi/wandb_bugfix
Update the name of the wandb callback
2 parents fb3e8e6 + edd306d commit 030c153

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

rslp/lightning_cli.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ def get_cached_checkpoint(checkpoint_fname: UPath) -> str:
7474
return local_fname
7575

7676

77-
class SaveWandbRunIdCallback(Callback):
77+
class SaveWandbRunIdCallbackRSLP(Callback):
7878
"""Callback to save the wandb run ID to GCS in case of resume."""
7979

8080
def __init__(
@@ -84,7 +84,7 @@ def __init__(
8484
run_id: str | None,
8585
config_str: str | None,
8686
) -> None:
87-
"""Create a new SaveWandbRunIdCallback.
87+
"""Create a new SaveWandbRunIdCallbackRSLP.
8888
8989
Args:
9090
project_id: the project ID.
@@ -365,7 +365,7 @@ def before_instantiate_classes(self) -> None:
365365
== "lightning.pytorch.callbacks.ModelCheckpoint"
366366
):
367367
checkpoint_callback = existing_callback
368-
if existing_callback.class_path == "SaveWandbRunIdCallback":
368+
if existing_callback.class_path == "SaveWandbRunIdCallbackRSLP":
369369
upload_wandb_callback = existing_callback
370370
else:
371371
c.trainer.callbacks = []
@@ -393,7 +393,7 @@ def before_instantiate_classes(self) -> None:
393393
)
394394
upload_wandb_callback = jsonargparse.Namespace(
395395
{
396-
"class_path": "SaveWandbRunIdCallback",
396+
"class_path": "SaveWandbRunIdCallbackRSLP",
397397
"init_args": jsonargparse.Namespace(
398398
{
399399
"project_id": c.rslp_project,

0 commit comments

Comments
 (0)