Skip to content

Save config.json to the project directory in RSLP_PREFIX #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025

Conversation

favyen2
Copy link
Collaborator

@favyen2 favyen2 commented Jun 26, 2025

Save config.json to the project directory in RSLP_PREFIX.

I also fixed bugs when RSLP_PREFIX is local filesystem relating to needing to create some parent directories. This way you can set RSLP_PREFIX to /weka/dfive-default/rslearn-eai/ before running model fit; it also works when launching job with common beaker_train since it takes the RSLP_PREFIX from the environment and passes it on to the Beaker job. Note that you will still need to pass command-line option to enable corresponding WEKA mount.

I also fixed bugs when RSLP_PREFIX is local filesystem relating to needing
to create some parent directories. This way you can set RSLP_PREFIX to
/weka/dfive-default/rslearn-eai/ before running `model fit`; it also works
when launching job with `common beaker_train` since it takes the RSLP_PREFIX
from the environment and passes it on to the Beaker job. Note that you will
still need to pass command-line option to enable corresponding WEKA mount.
@favyen2 favyen2 mentioned this pull request Jun 26, 2025
Copy link
Collaborator

@Hgherzog Hgherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@favyen2 favyen2 merged commit 9310be2 into master Jul 9, 2025
4 checks passed
@favyen2 favyen2 deleted the favyen/20250626-support-weka-checkpointing branch July 9, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants