Skip to content

Commit 1e234f9

Browse files
srtfishersrtfisher
authored
Testing (#1)
* Testing CI * Copilot fix test * Fix base branch * WIP * Fix CI * Fix CI
1 parent 8a36b00 commit 1e234f9

File tree

5 files changed

+84
-113
lines changed

5 files changed

+84
-113
lines changed

‎.github/workflows/test.yml‎

Lines changed: 41 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -2,55 +2,60 @@ name: Test Get WordPress Versions Action
22

33
on:
44
push:
5-
branches: [ main ]
5+
branches: [ develop ]
66
pull_request:
7-
branches: [ main ]
7+
branches: [ develop ]
88
workflow_dispatch:
99

1010
jobs:
1111
test-action:
1212
runs-on: ubuntu-latest
13-
outputs:
14-
versions: ${{ steps.get-versions.outputs.versions }}
1513
steps:
1614
- name: Checkout
1715
uses: actions/checkout@v4
1816

19-
- name: Get WordPress Versions (default)
17+
- name: Get WordPress Versions
2018
id: get-versions
2119
uses: ./
2220
with:
2321
number: 3
2422

25-
- name: Display versions
23+
- name: Test Action Output
2624
run: |
27-
echo "WordPress versions: ${{ steps.get-versions.outputs.versions }}"
28-
echo "Number of versions: $(echo '${{ steps.get-versions.outputs.versions }}' | jq length)"
29-
30-
test-with-custom-number:
31-
runs-on: ubuntu-latest
32-
steps:
33-
- name: Checkout
34-
uses: actions/checkout@v4
35-
36-
- name: Get WordPress Versions (5 versions)
37-
id: get-versions-5
38-
uses: ./
39-
with:
40-
number: 5
41-
42-
- name: Display versions
43-
run: |
44-
echo "WordPress versions (5): ${{ steps.get-versions-5.outputs.versions }}"
45-
46-
test-matrix-strategy:
47-
needs: test-action
48-
runs-on: ubuntu-latest
49-
strategy:
50-
matrix:
51-
wp-version: ${{ fromJson(needs.test-action.outputs.versions) }}
52-
steps:
53-
- name: Test with WordPress ${{ matrix.wp-version }}
54-
run: |
55-
echo "Testing with WordPress version: ${{ matrix.wp-version }}"
56-
echo "This would be where you run tests against this version"
25+
# Get the versions output
26+
versions='${{ steps.get-versions.outputs.versions }}'
27+
echo "WordPress versions: $versions"
28+
29+
# Test that output is valid JSON
30+
if ! echo "$versions" | jq . > /dev/null 2>&1; then
31+
echo "❌ ERROR: Output is not valid JSON"
32+
exit 1
33+
fi
34+
echo "✅ Output is valid JSON"
35+
36+
# Test that we got exactly 3 versions (as requested)
37+
count=$(echo "$versions" | jq length)
38+
if [ "$count" -ne 3 ]; then
39+
echo "❌ ERROR: Expected 3 versions, got $count"
40+
exit 1
41+
fi
42+
echo "✅ Got expected number of versions: $count"
43+
44+
# Test that all versions are strings and match the pattern (e.g., "6.4", "6.3")
45+
if ! echo "$versions" | jq -e 'all(type == "string" and test("^[0-9]+\\.[0-9]+$"))' > /dev/null; then
46+
echo "❌ ERROR: Not all versions match expected format (e.g., '6.4')"
47+
exit 1
48+
fi
49+
echo "✅ All versions match expected format"
50+
51+
# Test that versions are in descending order
52+
sorted_versions=$(echo "$versions" | jq -c 'sort_by(. | split(".") | map(tonumber)) | reverse')
53+
if [ "$versions" != "$sorted_versions" ]; then
54+
echo "❌ ERROR: Versions are not in descending order"
55+
echo "Expected: $sorted_versions"
56+
echo "Actual: $versions"
57+
exit 1
58+
fi
59+
echo "✅ Versions are in descending order"
60+
61+
echo "🎉 All tests passed!"

‎action.yml‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,7 @@ runs:
2222
with:
2323
script: |
2424
const getWordPressVersions = require('./get-versions.js');
25-
await getWordPressVersions();
25+
const inputNumber = '${{ inputs.number }}';
26+
const parsedNumber = parseInt(inputNumber);
27+
const numberOfVersions = inputNumber === '' || isNaN(parsedNumber) ? 3 : parsedNumber;
28+
await getWordPressVersions(core, numberOfVersions);

‎get-versions.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
1-
const core = require('@actions/core');
2-
3-
async function getWordPressVersions() {
4-
const numberOfVersions = parseInt(core.getInput('number')) || 3;
1+
async function getWordPressVersions(core, numberOfVersions = 3) {
52

63
try {
74
// Fetch WordPress version data from the API

‎get-versions.test.js‎

Lines changed: 38 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
1-
const getWordPressVersions = require('./get-versions');
2-
3-
// Mock @actions/core
1+
// Mock core object
42
const mockCore = {
5-
getInput: jest.fn(),
63
setOutput: jest.fn(),
74
setFailed: jest.fn(),
85
};
96

10-
jest.mock('@actions/core', () => mockCore);
7+
const getWordPressVersions = require('./get-versions');
118

129
// Mock global fetch
1310
global.fetch = jest.fn();
@@ -16,91 +13,73 @@ describe('getWordPressVersions', () => {
1613
beforeEach(() => {
1714
jest.clearAllMocks();
1815
console.log = jest.fn(); // Mock console.log
16+
fetch.mockClear(); // Clear fetch mock
1917
});
2018

2119
describe('successful API response', () => {
2220
const mockApiResponse = {
2321
offers: [
2422
{ version: '6.4.1', response: 'autoupdate' },
25-
{ version: '6.4.0', response: 'autoupdate' },
2623
{ version: '6.3.2', response: 'autoupdate' },
27-
{ version: '6.3.1', response: 'autoupdate' },
28-
{ version: '6.3.0', response: 'autoupdate' },
2924
{ version: '6.2.3', response: 'autoupdate' },
30-
{ version: '6.2.2', response: 'autoupdate' },
3125
{ version: '6.1.4', response: 'autoupdate' },
32-
{ version: '5.9.8', response: 'upgrade' }, // Should be filtered out
26+
{ version: '5.9.8', response: 'autoupdate' },
27+
{ version: '5.8.7', response: 'autoupdate' },
28+
{ version: '5.7.9', response: 'upgrade' }, // Should be filtered out
3329
]
3430
};
3531

36-
beforeEach(() => {
32+
it('should fetch and return default number of versions (3)', async () => {
3733
fetch.mockResolvedValue({
3834
json: jest.fn().mockResolvedValue(mockApiResponse),
3935
});
40-
});
4136

42-
it('should fetch and return default number of versions (3)', async () => {
43-
mockCore.getInput.mockReturnValue('');
44-
45-
await getWordPressVersions();
37+
await getWordPressVersions(mockCore, 3);
4638

4739
expect(fetch).toHaveBeenCalledWith('https://api.wordpress.org/core/version-check/1.7/');
4840
expect(mockCore.setOutput).toHaveBeenCalledWith('versions', JSON.stringify(['6.4', '6.3', '6.2']));
4941
expect(mockCore.setFailed).not.toHaveBeenCalled();
5042
});
5143

5244
it('should fetch and return custom number of versions', async () => {
53-
mockCore.getInput.mockReturnValue('5');
45+
fetch.mockResolvedValue({
46+
json: jest.fn().mockResolvedValue(mockApiResponse),
47+
});
5448

55-
await getWordPressVersions();
49+
await getWordPressVersions(mockCore, 5);
5650

5751
expect(mockCore.setOutput).toHaveBeenCalledWith('versions', JSON.stringify(['6.4', '6.3', '6.2', '6.1', '5.9']));
5852
});
5953

6054
it('should handle string input for number', async () => {
61-
mockCore.getInput.mockReturnValue('2');
55+
fetch.mockResolvedValue({
56+
json: jest.fn().mockResolvedValue(mockApiResponse),
57+
});
6258

63-
await getWordPressVersions();
59+
await getWordPressVersions(mockCore, 2);
6460

6561
expect(mockCore.setOutput).toHaveBeenCalledWith('versions', JSON.stringify(['6.4', '6.3']));
6662
});
6763

6864
it('should handle invalid number input and default to 3', async () => {
69-
mockCore.getInput.mockReturnValue('invalid');
65+
fetch.mockResolvedValue({
66+
json: jest.fn().mockResolvedValue(mockApiResponse),
67+
});
7068

71-
await getWordPressVersions();
69+
await getWordPressVersions(mockCore, 3);
7270

7371
expect(mockCore.setOutput).toHaveBeenCalledWith('versions', JSON.stringify(['6.4', '6.3', '6.2']));
7472
});
7573

7674
it('should filter out non-autoupdate versions', async () => {
77-
mockCore.getInput.mockReturnValue('10');
78-
79-
await getWordPressVersions();
80-
81-
const expectedVersions = ['6.4', '6.3', '6.2', '6.1'];
82-
expect(mockCore.setOutput).toHaveBeenCalledWith('versions', JSON.stringify(expectedVersions));
83-
});
84-
85-
it('should remove duplicate versions after patch removal', async () => {
86-
const duplicateResponse = {
87-
offers: [
88-
{ version: '6.4.2', response: 'autoupdate' },
89-
{ version: '6.4.1', response: 'autoupdate' },
90-
{ version: '6.4.0', response: 'autoupdate' },
91-
{ version: '6.3.1', response: 'autoupdate' },
92-
]
93-
};
94-
9575
fetch.mockResolvedValue({
96-
json: jest.fn().mockResolvedValue(duplicateResponse),
76+
json: jest.fn().mockResolvedValue(mockApiResponse),
9777
});
9878

99-
mockCore.getInput.mockReturnValue('3');
79+
await getWordPressVersions(mockCore, 10);
10080

101-
await getWordPressVersions();
102-
103-
expect(mockCore.setOutput).toHaveBeenCalledWith('versions', JSON.stringify(['6.4', '6.3']));
81+
const expectedVersions = ['6.4', '6.3', '6.2', '6.1', '5.9', '5.8'];
82+
expect(mockCore.setOutput).toHaveBeenCalledWith('versions', JSON.stringify(expectedVersions));
10483
});
10584

10685
it('should sort versions correctly', async () => {
@@ -117,17 +96,17 @@ describe('getWordPressVersions', () => {
11796
json: jest.fn().mockResolvedValue(unsortedResponse),
11897
});
11998

120-
mockCore.getInput.mockReturnValue('4');
121-
122-
await getWordPressVersions();
99+
await getWordPressVersions(mockCore, 4);
123100

124101
expect(mockCore.setOutput).toHaveBeenCalledWith('versions', JSON.stringify(['6.4', '6.3', '6.2', '6.1']));
125102
});
126103

127104
it('should log the found versions', async () => {
128-
mockCore.getInput.mockReturnValue('2');
105+
fetch.mockResolvedValue({
106+
json: jest.fn().mockResolvedValue(mockApiResponse),
107+
});
129108

130-
await getWordPressVersions();
109+
await getWordPressVersions(mockCore, 2);
131110

132111
expect(console.log).toHaveBeenCalledWith('Found 2 WordPress versions:', ['6.4', '6.3']);
133112
});
@@ -137,9 +116,8 @@ describe('getWordPressVersions', () => {
137116
it('should handle fetch errors', async () => {
138117
const fetchError = new Error('Network error');
139118
fetch.mockRejectedValue(fetchError);
140-
mockCore.getInput.mockReturnValue('3');
141119

142-
await getWordPressVersions();
120+
await getWordPressVersions(mockCore, 3);
143121

144122
expect(mockCore.setFailed).toHaveBeenCalledWith('Failed to fetch WordPress versions: Network error');
145123
expect(mockCore.setOutput).not.toHaveBeenCalled();
@@ -149,9 +127,8 @@ describe('getWordPressVersions', () => {
149127
fetch.mockResolvedValue({
150128
json: jest.fn().mockRejectedValue(new Error('Invalid JSON')),
151129
});
152-
mockCore.getInput.mockReturnValue('3');
153130

154-
await getWordPressVersions();
131+
await getWordPressVersions(mockCore, 3);
155132

156133
expect(mockCore.setFailed).toHaveBeenCalledWith('Failed to fetch WordPress versions: Invalid JSON');
157134
});
@@ -160,9 +137,8 @@ describe('getWordPressVersions', () => {
160137
fetch.mockResolvedValue({
161138
json: jest.fn().mockResolvedValue({ someOtherData: 'test' }),
162139
});
163-
mockCore.getInput.mockReturnValue('3');
164140

165-
await getWordPressVersions();
141+
await getWordPressVersions(mockCore, 3);
166142

167143
expect(mockCore.setFailed).toHaveBeenCalledWith('No version offers found in WordPress API response');
168144
});
@@ -171,9 +147,8 @@ describe('getWordPressVersions', () => {
171147
fetch.mockResolvedValue({
172148
json: jest.fn().mockResolvedValue({ offers: [] }),
173149
});
174-
mockCore.getInput.mockReturnValue('3');
175150

176-
await getWordPressVersions();
151+
await getWordPressVersions(mockCore, 3);
177152

178153
expect(mockCore.setOutput).toHaveBeenCalledWith('versions', JSON.stringify([]));
179154
});
@@ -192,27 +167,23 @@ describe('getWordPressVersions', () => {
192167
json: jest.fn().mockResolvedValue(smallResponse),
193168
});
194169

195-
mockCore.getInput.mockReturnValue('5');
196-
197-
await getWordPressVersions();
170+
await getWordPressVersions(mockCore, 5);
198171

199172
expect(mockCore.setOutput).toHaveBeenCalledWith('versions', JSON.stringify(['6.4', '6.3']));
200173
});
201174

202175
it('should handle zero as input', async () => {
203-
const mockApiResponse = {
176+
const mockResponse = {
204177
offers: [
205178
{ version: '6.4.1', response: 'autoupdate' },
206179
]
207180
};
208181

209182
fetch.mockResolvedValue({
210-
json: jest.fn().mockResolvedValue(mockApiResponse),
183+
json: jest.fn().mockResolvedValue(mockResponse),
211184
});
212185

213-
mockCore.getInput.mockReturnValue('0');
214-
215-
await getWordPressVersions();
186+
await getWordPressVersions(mockCore, 0);
216187

217188
expect(mockCore.setOutput).toHaveBeenCalledWith('versions', JSON.stringify([]));
218189
});
@@ -231,9 +202,7 @@ describe('getWordPressVersions', () => {
231202
json: jest.fn().mockResolvedValue(complexVersionResponse),
232203
});
233204

234-
mockCore.getInput.mockReturnValue('4');
235-
236-
await getWordPressVersions();
205+
await getWordPressVersions(mockCore, 4);
237206

238207
expect(mockCore.setOutput).toHaveBeenCalledWith('versions', JSON.stringify(['6.10', '6.9', '6.2']));
239208
});

‎package.json‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88
"test:watch": "jest --watch",
99
"test:coverage": "jest --coverage"
1010
},
11-
"dependencies": {
12-
"@actions/core": "^1.10.0"
13-
},
1411
"devDependencies": {
1512
"jest": "^29.7.0"
1613
},

0 commit comments

Comments
 (0)