Fix issue with unserialized data (#807)

Author: srtfisher

CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## v1.12.4
+
+### Fixed
+
+- Fixed issue with unserialization of cached HTTP client requests causing errors
+  due to uninitialized properties (again).
+
 ## v1.12.3
 
 ### Fixed

src/mantle/http-client/class-cache-flexible-middleware.php

@@ -9,6 +9,7 @@
 
 use Closure;
 use DateTimeInterface;
+use LogicException;
 use Mantle\Cache\SWR_Storage;
 
 use function Mantle\Support\Helpers\defer;
@@ -46,24 +47,22 @@ public function __construct( protected int|\DateInterval|\DateTimeInterface $sta
 	public function __invoke( Pending_Request $request, Closure $next ): Response {
 		$this->cache_key = $this->get_cache_key( $request );
 
-		$cache = wp_cache_get( $this->cache_key, self::CACHE_GROUP );
+		$cache = $this->get_cached_response();
 
-		if ( $cache && $cache instanceof SWR_Storage ) {
+		if ( $cache instanceof SWR_Storage && $cache->value instanceof Response ) {
 			$response = $cache->value;
 
-			if ( $response instanceof Response ) {
-				// If the cache is stale, we can still return it, but we should refresh
-				// deferred to the end of the request.
-				if ( $cache->is_stale() ) {
-					$fresh_request = ( clone $request )->without_middleware( Cache_Middleware::class );
+			// If the cache is stale, we can still return it, but we should refresh
+			// deferred to the end of the request.
+			if ( $cache->is_stale() ) {
+				$fresh_request = ( clone $request )->without_middleware( Cache_Middleware::class );
 
-					defer( fn () => $this->store_response( $fresh_request->send() ) );
-				}
+				defer( fn () => $this->store_response( $fresh_request->send() ) );
+			}
 
-				$response->cached = true;
+			$response->cached = true;
 
-				return $response;
-			}
+			return $response;
 		}
 
 		$response = $next( $request );
@@ -75,6 +74,25 @@ public function __invoke( Pending_Request $request, Closure $next ): Response {
 		return $response;
 	}
 
+	/**
+	 * Retrieve a cached response if available.
+	 *
+	 * @return SWR_Storage|null Cached response or null if not found.
+	 */
+	private function get_cached_response(): ?SWR_Storage {
+		try {
+			$cache = wp_cache_get( $this->cache_key, self::CACHE_GROUP );
+
+			if ( $cache && $cache instanceof SWR_Storage ) {
+				return $cache;
+			}
+
+			return null;
+		} catch ( LogicException ) {
+			return null;
+		}
+	}
+
 	/**
 	 * Store a response in the cache.
 	 *