Race Condition for Language Target When Formatting with %l (#1133)

Author: GLoOoccK

amxmodx/CLang.cpp

@@ -626,3 +626,8 @@ void CLangMngr::SetDefLang(int id)
 {
 	m_CurGlobId = id;
 }
+
+void CLangMngr::SetFmtLang(int id)
+{
+	m_CurFmtId = id;
+}

amxmodx/CLang.h

@@ -130,6 +130,7 @@ class CLangMngr : public ITextListener_INI
 
 	// Current global client-id for functions like client_print with first parameter 0
 	int m_CurGlobId;
+	int m_CurFmtId;
 public:
 	// Merge a definitions file
 	int MergeDefinitionFile(const char *file);
@@ -156,8 +157,10 @@ class CLangMngr : public ITextListener_INI
 
 	// When a language id in a format string in FormatAmxString is LANG_PLAYER, the glob id decides which language to take.
 	void SetDefLang(int id);
+	void SetFmtLang(int id);
 
 	inline int GetDefLang() const { return m_CurGlobId; }
+	inline int GetFmtLang() const { return m_CurFmtId; }
 
 	// Reset
 	void Clear();

amxmodx/amxmodx.cpp

@@ -4625,7 +4625,7 @@ static cell AMX_NATIVE_CALL LookupLangKey(AMX *amx, cell *params)
 // SetGlobalTransTarget(client)
 static cell AMX_NATIVE_CALL SetGlobalTransTarget(AMX *amx, cell *params)
 {
-	g_langMngr.SetDefLang(params[1]);
+	g_langMngr.SetFmtLang(params[1]);
 
 	return 1;
 };

amxmodx/format.cpp

@@ -693,7 +693,7 @@ size_t atcprintf(D *buffer, size_t maxlen, const S *format, AMX *amx, cell *para
 				else
 				{
 					CHECK_ARGS(0);
-					lang = playerlang(g_langMngr.GetDefLang());
+					lang = playerlang(g_langMngr.GetFmtLang());
 				}
 				const char *key = get_amxstring(amx, params[arg++], 3, len);
 				const char *def = translate(amx, lang, key);