Update CI workflow (#1132)

* Update linux runner to ubuntu-22.04

Ubuntu 18.04 and 20.04 runner images have been deprecated and removed.
References:
  https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/
  https://github.blog/changelog/2025-01-15-github-actions-ubuntu-20-runner-image-brownout-dates-and-other-breaking-changes/

* Update Python to 3.9

The pip installer (get-pip.py) requires Python 3.9 as the minimum
supported version. See:
https://raw.githubusercontent.com/pypa/get-pip/5b6af739d6c6547ab54e799349434f2fc9d95846/public/get-pip.py

* Update actions/checkout to v4

* Remove MacOS from job matrix

* Consolidate Windows runners to windows-2022

Remove windows-latest and windows-2016 entries. MSVC 14.16 toolset is no
longer available on windows runners.
See: actions/runner-images#12764

* Update ubuntu-22.04 compiler versions to oldest available

Replace gcc-6 and clang-3.9 with gcc-9 and clang-11 (oldest versions
available in ubuntu-22.04). The ubuntu-18.04 GitHub runner image has been
deprecated and removed, replaced by ubuntu-22.04.

See:
  https://packages.ubuntu.com/jammy/gcc
  https://packages.ubuntu.com/jammy/clang

* Remove all macOS references from CI

* Add github-actions-update branch to CI push triggers

* Add artifact upload to CI workflow

* Remove OS prefix from job titles

* Disable ubuntu-latest builds due to compiler compatibility issues

* Remove github-actions-update from branches built on push

Author: MisterCalvin

.github/workflows/ci.yml

@@ -14,57 +14,49 @@ jobs:
     strategy:
       matrix:
         include:
-          - os: ubuntu-latest
+          # - os: ubuntu-latest
+          #   os_short: linux
+          #   compiler_cc: gcc
+          #   compiler_cxx: g++
+          # - os: ubuntu-latest
+          #   os_short: linux
+          #   compiler_cc: clang
+          #   compiler_cxx: clang++
+          - os: ubuntu-22.04
             os_short: linux
-            compiler_cc: gcc
-            compiler_cxx: g++
-          - os: ubuntu-latest
+            compiler_cc: clang-11
+            compiler_cxx: clang++-11
+          - os: ubuntu-22.04
             os_short: linux
-            compiler_cc: clang
-            compiler_cxx: clang++        
-          - os: ubuntu-18.04
-            os_short: linux
-            compiler_cc: clang-3.9
-            compiler_cxx: clang++-3.9
-          - os: ubuntu-18.04
-            os_short: linux
-            compiler_cc: gcc-6
-            compiler_cxx: g++-6
-            compiler_install: 'g++6 g++-6-multilib'
-          - os: windows-latest
+            compiler_cc: gcc-9
+            compiler_cxx: g++-9
+            compiler_install: 'gcc-9-multilib g++-9-multilib'
+          - os: windows-2022
             os_short: windows
             compiler_cc: msvc
-          - os: windows-2016
-            os_short: windows
-            compiler_cc: msvc++14.16-vs2017-cl
-# MacOS 32 Bins seem not supported
-#           - os: macos-latest
-#             os_short: mac
-#             compiler_cc: clang
-#             compiler_cxx: clang++            
       fail-fast: false
     runs-on: ${{ matrix.os }}
-    name: ${{ matrix.os_short }}-${{ matrix.os }}-${{ matrix.compiler_cc }}
+    name: ${{ matrix.os_short }}-${{ matrix.compiler_cc }}
     env:
       DEPENDENCIES_FOLDER: dependencies      
       DEPENDENCIES_ROOT: ${{ github.workspace }}/dependencies      
       DEPENDENCIES_ROOT_WIN: ${{ github.workspace }}\dependencies              
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
           path: amxmodx
       # Setup Python for AMBuild
       - uses: actions/setup-python@v2
-        name: Setup Python 3.8
+        name: Setup Python 3.9
         with:
-          python-version: 3.8
+          python-version: 3.9
       - name: Install Python dependencies
         run: |
           python3 -m pip install --upgrade pip setuptools wheel
           python3 --version
       - name: Install AMXModX dependencies (Linux)
-        if: startsWith(runner.os, 'Linux') || startsWith(runner.os, 'macOS')
+        if: startsWith(runner.os, 'Linux')
         shell: bash
         run: |
           mkdir -p ${{ env.DEPENDENCIES_FOLDER }}
@@ -113,14 +105,21 @@ jobs:
           ${{ matrix.compiler_cc }} --version
           ${{ matrix.compiler_cxx }} --version
       - uses: ilammy/setup-nasm@v1
-      - name: Build Linux/macOS
-        if: startsWith(runner.os, 'Linux') || startsWith(runner.os, 'macOS')
+      - name: Build Linux
+        if: startsWith(runner.os, 'Linux')
         working-directory: amxmodx
         run: |
           mkdir build
           cd build
           python3 ../configure.py --enable-optimize --metamod=${{ env.DEPENDENCIES_ROOT }}/metamod-am --hlsdk=${{ env.DEPENDENCIES_ROOT }}/hlsdk --mysql=${{ env.DEPENDENCIES_ROOT }}/mysql-5.5
           ambuild
+      - name: Upload Linux artifacts
+        if: startsWith(runner.os, 'Linux') && always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: amxmodx-${{ matrix.os_short }}-${{ matrix.compiler_cc }}-${{ github.sha }}
+          path: amxmodx/build/packages/
+          retention-days: 7
       - uses: ilammy/msvc-dev-cmd@v1
         with:
           arch: x86
@@ -134,4 +133,10 @@ jobs:
           cd build
           python3 ../configure.py --enable-optimize --metamod=${{ env.DEPENDENCIES_ROOT_WIN }}\metamod-am --hlsdk=${{ env.DEPENDENCIES_ROOT_WIN }}\hlsdk --mysql=${{ env.DEPENDENCIES_ROOT_WIN }}\mysql-5.5
           ambuild
-          
+      - name: Upload Windows artifacts
+        if: startsWith(runner.os, 'Windows') && always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: amxmodx-${{ matrix.os_short }}-${{ matrix.compiler_cc }}-${{ github.sha }}
+          path: amxmodx/build/packages/
+          retention-days: 7