Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] add ssz support for beacon request types #1004

Closed
mattsse opened this issue Jul 2, 2024 · 2 comments
Closed

[Feature] add ssz support for beacon request types #1004

mattsse opened this issue Jul 2, 2024 · 2 comments
Assignees
@yash-atreya
Labels
c-rpc-types-beacon Pertaining to the rpc-types-beacon crate enhancement New feature or request good first issue Good for newcomers P-low Low Priority
Milestone
v1.0

Comments

@mattsse
Copy link
Member

mattsse commented Jul 2, 2024

Component

rpc

Describe the feature you would like

spec: https://flashbots.github.io/relay-specs/#/

blocks can be submitted as josn or ssz

we currently don't have ssz support for the submit types:

alloy/crates/rpc-types-beacon/src/relay.rs

Lines 125 to 129 in 095ed89

/// Submission for the `/relay/v1/builder/blocks` endpoint (Deneb).
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
#[cfg_attr(feature = "ssz", derive(ssz_derive::Decode, ssz_derive::Encode))]
pub struct SignedBidSubmissionV3 {

TODO

  • add ssz support, payload types already have ssz:

    alloy/crates/rpc-types-engine/src/payload.rs

    Lines 142 to 144 in 095ed89

    #[serde(rename_all = "camelCase")]
    #[cfg_attr(feature = "ssz", derive(ssz_derive::Encode, ssz_derive::Decode))]
    pub struct ExecutionPayloadV1 {

see also:
https://github.com/flashbots/builder/blob/df9c765067d57ab4b2d0ad39dbb156cbe4965778/builder/relay.go#L137-L154C31
https://github.com/attestantio/go-builder-client/blob/73e0a0b2ce80aac4db7705ac3af06e6b85b0d64a/api/deneb/submitblockrequest_ssz.go#L14

Additional context

No response
@mattsse mattsse added enhancement New feature or request good first issue Good for newcomers labels Jul 2, 2024
@programskillforverification
Copy link
Contributor

I want to try this. Could you assign to me?

Closed
3 tasks
@yash-atreya yash-atreya added this to the v1.0 milestone Feb 28, 2025
@yash-atreya yash-atreya added c-rpc-types-beacon Pertaining to the rpc-types-beacon crate P-low Low Priority labels Feb 28, 2025
@jenpaff jenpaff added this to Alloy Feb 28, 2025
@github-project-automation github-project-automation bot moved this to Todo in Alloy Feb 28, 2025
@jenpaff jenpaff moved this from Todo to Ready for Review in Alloy Mar 4, 2025
@jenpaff jenpaff assigned yash-atreya and unassigned mattsse Mar 13, 2025
@jenpaff jenpaff moved this from Ready for Review to In Progress in Alloy Mar 13, 2025
@yash-atreya
Copy link
Member

We don't need this anymore as the SubmitBlockRequest was removed in #1577.

Moreover, ssz derived for all SignedBidSubmission types.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Alloy Mar 18, 2025
@grandizzy grandizzy moved this from Done to Completed in Alloy Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yash-atreya yash-atreya

Labels
c-rpc-types-beacon Pertaining to the rpc-types-beacon crate enhancement New feature or request good first issue Good for newcomers P-low Low Priority
Projects
Alloy
Status: Completed
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

feat: add ssz support for beacon request types programskillforverification/alloy
3 participants
@mattsse @yash-atreya @programskillforverification