Skip to content

[Feature] Rework JoinFill using tuple approach #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yash-atreya opened this issue Apr 1, 2025 · 0 comments · May be fixed by #2261
Open

[Feature] Rework JoinFill using tuple approach #2265

yash-atreya opened this issue Apr 1, 2025 · 0 comments · May be fixed by #2261
Assignees
Labels
c-provider enhancement New feature or request
Milestone

Comments

@yash-atreya
Copy link
Member

Component

provider, pubsub

Describe the feature you would like

Currently, the JoinFill implementation leads to highly verbose provider types.

Image

We can improve this by using a tuple approach that removes layering and reduces verbosity.

e.g tuple Fillers<(GasFiller, NonceFiller, ChainIdFiller)>

We can achieve the above without perf cost as this approach doesn't use dynamic dispatch.

Additional context

No response

@yash-atreya yash-atreya added the enhancement New feature or request label Apr 1, 2025
@yash-atreya yash-atreya added this to the v1.0 milestone Apr 1, 2025
@yash-atreya yash-atreya self-assigned this Apr 1, 2025
@github-project-automation github-project-automation bot moved this to Todo in Alloy Apr 1, 2025
@yash-atreya yash-atreya linked a pull request Apr 1, 2025 that will close this issue
3 tasks
@yash-atreya yash-atreya moved this from Todo to Ready for Review in Alloy Apr 1, 2025
@grandizzy grandizzy moved this from Ready for Review to Reviewed in Alloy Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-provider enhancement New feature or request
Projects
Status: Reviewed
Development

Successfully merging a pull request may close this issue.

1 participant