Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace EthereumWallet with just the signer #197

Open
yash-atreya opened this issue Mar 18, 2025 · 1 comment
Open

chore: replace EthereumWallet with just the signer #197

yash-atreya opened this issue Mar 18, 2025 · 1 comment

Comments

@yash-atreya
Copy link
Member

Since alloy-rs/alloy#2120, We can pass the signer directly into the ProviderBuilder without the need for encapsulating it in an EthereumWallet.

Replace all instances of EthereumWallet being passed to ProviderBuilder via .wallet(..) with just the signer being passed .wallet(signer).
@github-project-automation github-project-automation bot moved this to Todo in Alloy Mar 18, 2025
@yash-atreya
Copy link
Member Author

#56 should be done as followup to demonstrate the benefits of using EthereumWallet over just a signer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Alloy
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yash-atreya