allure-framework/allure-phpunit will require PHP 8.4 support

[glo71317]

Is your feature request related to a problem? Please describe.
PHP 8.4 is scheduled for general release on November 21, 2024 and we planned to php8.4 support for adobe commerce.

Describe the solution you'd like
We need to add php 8.4 support in composer.json and create one PR which is very straight forward. It may required some other dependency which will also required to get support php8.4.

Describe alternatives you've considered
I don't think there is any alternate will be available or help.

Additional context
NA

[glo71317]

@baev I hope you're doing well! With PHP 8.4 scheduled for general release on November 21, 2024, I was wondering if there are any plans to add support for PHP 8.4 in the allure-framework/allure-phpunit library.

I believe it would be a great addition for users who plan to upgrade to PHP 8.4, and it could help ensure that allure-phpunit remains compatible with the latest PHP features and improvements.

If you're open to it, I’d be happy to contribute a PR to help integrate PHP 8.4 support. Please let me know your thoughts, and I can proceed with drafting the necessary changes.

Thank you for your time and consideration!

[glo71317]

@baev Greetings for the day! As PHP 8.4 is available for GA, So are we plan to add support PHP 8.4 for allure-framework/allure-phpunit because right now it is blocking to update the PHP 8.4 in adobe commerce. You will suggest if required from our end then we can also provide the PR for PHP 8.4 support. Thanks

[glo71317]

I have created a PR for PHP 8.4 Support - #112

[krchiper]

If you add PHP-8.4 to the test matrix, the tests fails. So I guess its also necessary to get the tests to pass with PHP-8.4

I have looked into it, and struggle with maintaining backwards compatibility with previous versions of PHP.

php-8.4 requires phpunit 12, which have changed [#CoversClass] to only be valid for class's and introduced a #[CoversTrait] for traits. This result in ExceptionDetailsTraitTest can't be both be compatible with phpunit 11 and phpunit 12

PHPUnit 12 version

#[CoversTrait(ExceptionDetailsTrait::class)]
class ExceptionDetailsTraitTest extends TestCase

PHPUnit 11 version

#[CoversClass(ExceptionDetailsTrait::class)]
class ExceptionDetailsTraitTest extends TestCase

Would a patch be accepted that drop support for php 8.1, 8.2 and 8.3? or any ideas how to work around this?

[glo71317]

Dropping support for PHP 8.1, 8.2, and 8.3 may not be a good idea, as PHPUnit 10 supports PHP >=8.1 and has long-term support. Forcing users to upgrade to PHPUnit 11 or 12 could have a significant impact, especially for large frameworks like Adobe Commerce, as these upgrades require considerable time and effort to adapt to the changes.

A better approach would be to release a patch for allure-framework/allure-phpunit that adds PHP 8.4 support without upgrading PHPUnit. This way, we ensure compatibility while minimizing disruptions.

However, if we decide to drop support for PHP 8.1, 8.2, and 8.3, we should release a major version update for allure-framework/allure-phpunit, as it may introduce breaking changes (BIC). That said, if we can achieve PHP 8.4 support with minimal or no breaking changes, releasing a patch instead of a major version would be ideal.

I will ask the team to review and ensure all tests pass before proceeding.

[krchiper]

I have submitted PR #115, it has open issue with ExceptionDetailsTraitTest