Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make isSupported() part of our public API #5210

Closed
2 of 3 tasks
Tracked by #5205
romaricpascal opened this issue Aug 8, 2024 · 1 comment · Fixed by #5250
Closed
2 of 3 tasks
Tracked by #5205

Make isSupported() part of our public API #5210

romaricpascal opened this issue Aug 8, 2024 · 1 comment · Fixed by #5250
Assignees
@patrickpatrickpatrick
Labels
javascript

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Aug 8, 2024 •
edited by patrickpatrickpatrick
Loading

What

Make isSupported() public and export it in all.mjs

Why

So services can check whether GOV.UK Frontend is supported the same way our code does, reducing duplication.

Who needs to work on this

Developers, Content writers

Who needs to review this

Developers, Content writers

Done when

  • isSupported() is made available in all.mjs
  • isSupported() is documented as public in the JSDoc
  • The feature is documented in the Frontend Docs
@romaricpascal romaricpascal mentioned this issue Aug 8, 2024
Closed
@romaricpascal romaricpascal moved this to Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Aug 8, 2024
Merged
@romaricpascal romaricpascal moved this from Backlog 🏃🏼‍♀️ to In progress 📝 in GOV.UK Design System cycle board Aug 20, 2024
@patrickpatrickpatrick patrickpatrickpatrick moved this from In progress 📝 to Ready to release 🚀 in GOV.UK Design System cycle board Aug 20, 2024
@romaricpascal
Copy link
Member Author

Added an item to the Docs tasklist of the epic (#5205) so we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickpatrickpatrick patrickpatrickpatrick

Labels
javascript
Projects
GOV.UK Design System cycle board
Status: Ready to release 🚀
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add isSupported to all.mjs alphagov/govuk-frontend
2 participants
@romaricpascal @patrickpatrickpatrick