Add specialist finder index as part of all indices for creation

Previously we thought we should exclude specialist finder index from all indices in case there are stats that are dependent on these indices just in case we are double counting documents. However, it looks like the monitoring task just sends all the data to statsd and the stats ruby file under bin only looks at govuk only anyways and not specialist finder index. We should be good to add specialist finder index as part of "all indeces"

Author: minhngocd

lib/search_config.rb

@@ -43,7 +43,7 @@ def index_names
     def all_index_names
       # this is used to process data in the rake file when `all` is passed in as previous we skipped `govuk`
       # we can't update index_names at this stage as it is used in multiple spots including the index filtering
-      content_index_names + auxiliary_index_names + [govuk_index_name]
+      content_index_names + auxiliary_index_names + [govuk_index_name, specialist_finder_index_name]
     end
 
     def run_search(raw_parameters)

spec/support/index_helpers.rb

@@ -9,11 +9,11 @@ def self.setup_test_indexes
   end
 
   def self.all_index_names
-    SearchConfig.content_index_names + SearchConfig.auxiliary_index_names + [SearchConfig.govuk_index_name]
+    SearchConfig.content_index_names + SearchConfig.auxiliary_index_names + [SearchConfig.govuk_index_name, SearchConfig.specialist_finder_index_name]
   end
 
   def self.clean_all
-    all_index_names.append(SearchConfig.specialist_finder_index_name).each do |index_name|
+    all_index_names.each do |index_name|
       clean_index_group(index_name)
     end
   end
@@ -36,7 +36,7 @@ def self.clean_index_group(index_name)
   end
 
   def self.create_all
-    all_index_names.append(SearchConfig.specialist_finder_index_name).each do |index|
+    all_index_names.each do |index|
       create_test_index(index)
     end
   end