#10790 fix rubocop offences

Author: alexandermeindl

lib/redmine_privacy_terms.rb

@@ -21,6 +21,8 @@ def valid_terms_url?
 
       wiki_page = project.wiki&.find_page page
       return true if wiki_page.present?
+
+      false
     end
 
     def valid_terms_reject_url?
@@ -36,6 +38,8 @@ def valid_terms_reject_url?
 
       wiki_page = project.wiki&.find_page page
       return true if wiki_page.present?
+
+      false
     end
 
     def terms_url(lang = nil)
@@ -75,7 +79,7 @@ def terms_reject_url(lang = nil)
     end
 
     def external_page?(page)
-      return true if page.include?('http:') || page.include?('https:')
+      page.include?('http:') || page.include?('https:')
     end
 
     private

test/test_helper.rb

@@ -20,12 +20,12 @@ class TestCase
     include ActionDispatch::TestProcess
 
     def self.prepare
-      Role.where(id: [1, 2]).each do |r|
+      Role.where(id: [1, 2]).find_each do |r|
         r.permissions << :view_wiki_pages
         r.save
       end
 
-      Project.where(id: [1, 2]).each do |project|
+      Project.where(id: [1, 2]).find_each do |project|
         EnabledModule.create project: project, name: 'wiki'
       end
     end