Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 Support #63

Open
Trikolon opened this issue Jul 18, 2018 · 2 comments
Open

IPv6 Support #63

Trikolon opened this issue Jul 18, 2018 · 2 comments

Comments

@Trikolon
Copy link

The plugin doesn't seem to support IPv6 connections. I've just tested this by connecting to a BungeeCord instance via IPv6:
image

@Trikolon
Copy link
Author

Trikolon commented Jul 18, 2018

Gained some more insight:
The error occurs because of this check for valid ip: https://github.com/alphartdev/BungeeAdminTools/blob/master/src/main/java/fr/Alphart/BAT/Modules/Ban/Ban.java#L216

Since the regex for the IP check only matches IPv4 it will treat IPv6 adresses as "players" and will send those to the Mojang API. The API returns a null pointer, hence the exception.

@yannicklamprecht
Copy link

@Trikolon You mean REGEX recognises only ipv4 ? So v6 is detected as a player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants