Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rouge syntax highlighting not compatible with Distill theme #3001

Open
2 tasks done
jacobaustin123 opened this issue Feb 5, 2025 · 2 comments
Open
2 tasks done

Rouge syntax highlighting not compatible with Distill theme #3001

jacobaustin123 opened this issue Feb 5, 2025 · 2 comments
Labels

Comments

@jacobaustin123
Copy link
Contributor

Have you checked that your issue isn't already filed?

  • I read through FAQ and searched through the past issues, none of which addressed my issue.
  • Yes, I have checked that this issue isn't already filed.

Bug description

The default Rouge syntax highlighting doesn't work with the distill template.v2.js file, which tries to install its own highlighter

How to reproduce the bug

This is broken even on the provided distill example: https://alshedivat.github.io/al-folio/blog/2021/distill/. You'll notice the code syntax highlighting uses e.g. class token keyword which isn't part of the rogue/pygments css class: https://github.com/richleland/pygments-css/blob/master/friendly.css.

To resolve this, you should delete the prism code in template.v2.js (prism is the custom highlighter it uses). I haven't include code with this in case it is already known/considered.

Error messages and logs

The error message you got, with the full traceback if available. Please paste it between these triple backticks.

What operating system are you using?

Mac

Where are you seeing the problem on?

Running locally without Docker

More info

No response

@george-gca
Copy link
Collaborator

No, the idea initially was to use the distill template as-is, so if an update ever came up, we could simply overwrite our file. But since this probably will never happen, I think it is same if we customize the template to better fit our theme. We accept PRs on this matter.

@jacobaustin123
Copy link
Contributor Author

I filed #3002 for this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants