Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make abbr color inside bibliography a variable #3012

Open
2 tasks done
diaoenmao opened this issue Feb 11, 2025 · 2 comments · May be fixed by #3017
Open
2 tasks done

Make abbr color inside bibliography a variable #3012

diaoenmao opened this issue Feb 11, 2025 · 2 comments · May be fixed by #3017

Comments

@diaoenmao
Copy link

Have you checked that your feature request isn't already filed?

  • I read through FAQ and searched through the past issues, none of which addressed my feature request.
  • Yes, I have checked that this feature request isn't already filed.

Description & Motivation

Currently, the abbr color inside cv is defined as color: var(--global-card-bg-color) !important; in _sass/_base.scss
/_base.scss`

// CV

.cv {
  margin-bottom: 40px;

  .card {
    background-color: var(--global-card-bg-color);
    border: 1px solid var(--global-divider-color);

    .list-group-item {
      background-color: inherit;
      border-color: var(--global-divider-color);

      .badge {
        color: var(--global-card-bg-color) !important;
        background-color: var(--global-theme-color) !important;
      }
    }
  }
}

However, the similar style is not a variable inside bibliography. It seems like it is always white.

 .abbr {
        margin-bottom: 0.5rem;

        abbr {
          display: inline-block;
          background-color: var(--global-theme-color);
          margin-bottom: 0.5rem;

          a {
            color: white;

            &:hover {
              text-decoration: none;
            }
          }
        }

        .award {
          color: var(--global-theme-color) !important;
          border: 1px solid var(--global-theme-color);
        }
      }

I need to add color: var(--global-card-bg-color) !important; after margin-bottom: 0.5rem; to obtain the similar style in cv.

Pitch

No response

Alternatives

No response

Additional context

No response

@diaoenmao diaoenmao changed the title Make badge color inside bibliography a variable Make abbrv color inside bibliography a variable Feb 11, 2025
@diaoenmao diaoenmao changed the title Make abbrv color inside bibliography a variable Make abbr color inside bibliography a variable Feb 11, 2025
@george-gca
Copy link
Collaborator

Can you create a PR for this?

@diaoenmao diaoenmao linked a pull request Feb 14, 2025 that will close this issue
@diaoenmao
Copy link
Author

I have created the PR #3017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants