Merge pull request #1 from alt-ctrl-dev/alt-ctrl-dev-patch-1

refactor: updated text

Author: alt-ctrl-dev

lib/aba_viewer_web/live/aba_live/index.ex

@@ -98,7 +98,8 @@ defmodule AbaViewerWeb.AbaLive.Index do
 
   defp issue_error(:bsb_filler), do: "Incorrect BSB filler"
   defp issue_error(:records_mismatch), do: "Records count don't match"
-  defp issue_error(:bsb), do: "BSB is incorrect"
+  defp issue_error(:bsb), do: "Incorrect BSB"
+  defp issue_error(:account_number), do: "Incorrect Account Number"
   defp issue_error(x), do: x
 
   defp handle_progress(
@@ -152,7 +153,7 @@ defmodule AbaViewerWeb.AbaLive.Index do
     <div class="p-4 mb-4 text-sm text-red-800 rounded-lg bg-red-50 dark:bg-gray-800 dark:text-red-400" role="alert">
       <div class="flex space-x-4">
         <Heroicons.exclamation_circle class="w-6 h-6 text-red-900 fill-red-200" />
-        <p>Descriptive record has the following error: <%= error_to_string(@error) %></p>
+        <p>Descriptive record has the following issue(s): <%= error_to_string(@error) %></p>
       </div>
     </div>
     """
@@ -179,7 +180,7 @@ defmodule AbaViewerWeb.AbaLive.Index do
     <div class="p-4 mb-4 text-sm text-red-800 rounded-lg bg-red-50 dark:bg-gray-800 dark:text-red-400" role="alert">
     <div class="flex space-x-4">
       <Heroicons.exclamation_circle class="w-6 h-6 text-red-900 fill-red-200" />
-      <p>File Total record has the following error: <%= error_to_string(@error) %></p>
+      <p>File Total record has the following issue(s): <%= error_to_string(@error) %></p>
     </div>
     </div>
     """
@@ -205,7 +206,7 @@ defmodule AbaViewerWeb.AbaLive.Index do
     <div class="p-4 mb-4 text-sm text-red-800 rounded-lg bg-red-50 dark:bg-gray-800 dark:text-red-400" role="alert">
     <div class="flex space-x-4">
       <Heroicons.exclamation_circle class="w-6 h-6 text-red-900 fill-red-200" />
-      <p>Detail record has the following error: <%= error_to_string(@error) %></p>
+      <p>Detail record has the following issue(s): <%= error_to_string(@error) %></p>
     </div>
     </div>
     """
@@ -219,7 +220,7 @@ defmodule AbaViewerWeb.AbaLive.Index do
     <div class="p-4 mb-4 text-sm text-red-800 rounded-lg bg-red-50 dark:bg-gray-800 dark:text-red-400" role="alert">
     <div class="flex space-x-4">
       <Heroicons.exclamation_circle class="w-6 h-6 text-red-900 fill-red-200" />
-      <p>Detail record has the following error on line <%= @line %>: <%= error_to_string(@error) %></p>
+      <p>Detail record has the following issue(s) on line <%= @line %>: <%= error_to_string(@error) %></p>
     </div>
     </div>
     """

lib/aba_viewer_web/live/aba_live/index.html.heex

@@ -1,4 +1,4 @@
-<p class="mb-4 text-4xl font-extrabold leading-none tracking-tight text-gray-900 md:text-5xl lg:text-6xl dark:text-white text-center">Aba Viewer</p>
+<p class="mb-4 text-4xl font-extrabold leading-none tracking-tight text-gray-900 md:text-5xl lg:text-6xl dark:text-white text-center">ABA Viewer</p>
 <p class="mb-6 text-lg font-normal text-gray-500 lg:text-xl dark:text-gray-400 text-center">This tool will help you quickly identify issues with your ABA file.</p>
 <p class="mb-6 text-sm font-normal text-gray-500 lg:text-lg dark:text-gray-400 text-center"><span class="font-bold text-black dark:text-white">NOTE:</span> This tool will never save your ABA file.</p>
 <p class="mb-6 text-sm font-normal text-gray-500 lg:text-lg dark:text-gray-400 text-center"><span class="font-bold text-black dark:text-white">NOTE:</span> The library used to validate the file might have some issue. If you notice them, please report the issues <a class="underline" href="https://github.com/alt-ctrl-dev/aba-viewer/issues">here</a> </p>

test/aba_viewer_web/live/aba_live_test.exs

@@ -7,7 +7,7 @@ defmodule AbaViewerWeb.AbaLiveTest do
     test "lists all validator", %{conn: conn} do
       {:ok, _index_live, html} = live(conn, ~p"/")
 
-      assert html =~ "Aba Viewer"
+      assert html =~ "ABA Viewer"
       # assert html =~ "This tool will help you quickly identify issues with your ABA file."
       # assert html =~ "Click to upload or drag and drop your ABA file"
     end