Skip to content

Commit 39ba1ae

Browse files
authored
Update contributing.md with Spark install instructions (#1232)
* Update contributing.md * Update release_notes.rst * Update contributing.md * Update contributing.md * Update Makefile * Update contributing.md * Update contributing.md
1 parent 3241dfd commit 39ba1ae

File tree

3 files changed

+24
-4
lines changed

3 files changed

+24
-4
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ lint-fix:
2020
python docs/notebook_version_standardizer.py standardize
2121

2222
.PHONY: test
23-
test: lint
23+
test:
2424
pytest woodwork/
2525

2626
.PHONY: testcoverage
27-
testcoverage: lint
27+
testcoverage:
2828
pytest woodwork/ --cov=woodwork
2929

3030
.PHONY: installdeps

contributing.md

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,26 @@ Whether you are a novice or experienced software developer, all contributions an
2424
make installdeps
2525
git checkout -b issue####-branch_name
2626
```
27-
27+
* You will need to install Spark & Scala to run all unit tests:
28+
29+
**macOS** (use [Homebrew](https://brew.sh/)):
30+
```bash
31+
brew tap AdoptOpenJDK/openjdk
32+
brew install --cask adoptopenjdk11
33+
brew install scala
34+
brew install apache-spark
35+
```
36+
37+
**Ubuntu**:
38+
```bash
39+
sudo apt install openjdk-11-jre openjdk-11-jdk scala -y
40+
```
41+
42+
**Amazon Linux**:
43+
```bash
44+
sudo amazon-linux-extras install java-openjdk11 scala -y
45+
```
46+
2847
#### 2. Implement your Pull Request
2948

3049
* Implement your pull request. If needed, add new tests or update the documentation.

docs/source/release_notes.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,12 @@ Future Release
99
* Fixes
1010
* Changes
1111
* Documentation Changes
12+
* Updating contributing doc with Spark installat instructions (:pr:`1232`)
1213
* Testing Changes
1314
* Enable auto-merge for minimum and latest dependency merge requests (:pr:`1228`)
1415

1516
Thanks to the following people for contributing to this release:
16-
:user:`gsheni`
17+
:user:`gsheni`, :user:`willsmithorg`
1718

1819
v0.11.0 Dec 22, 2021
1920
====================

0 commit comments

Comments
 (0)