Validate schema's index if being used in partial schema init (#1115)

* validate schemas index if being used

* remove comment

* Add release note

* move schema index validation to validate_params function and fix falsy names bug

* add second release note

Author: tamargrey

docs/source/release_notes.rst

@@ -3,15 +3,18 @@
 Release Notes
 -------------
 
-.. Future Release
-  ===============
-  * Enhancements
-  * Fixes
-  * Changes
-  * Documentation Changes
-  * Testing Changes
-
-.. Thanks to the following people for contributing to this release:
+Future Release
+===============
+    * Enhancements
+    * Fixes
+        * Validate schema's index if being used in partial schema init (:pr:`1115`)
+        * Allow falsy index, time index, and name values to be set along with partial schema at init (:pr:`1115`)
+    * Changes
+    * Documentation Changes
+    * Testing Changes
+
+    Thanks to the following people for contributing to this release:
+    :user:`tamargrey`
 
 v0.7.0 Aug 25, 2021
 ===================

woodwork/table_accessor.py

@@ -188,9 +188,9 @@ def init_with_partial_schema(self,
         existing_col_origins = {}
 
         if schema:  # pull schema parameters
-            name = name or schema.name
-            index = index or schema.index
-            time_index = time_index or schema.time_index
+            name = name if name is not None else schema.name
+            index = index if index is not None else schema.index
+            time_index = time_index if time_index is not None else schema.time_index
             table_metadata = table_metadata or schema.metadata
             for col_name, col_schema in schema.columns.items():
                 existing_logical_types[col_name] = col_schema.logical_type
@@ -951,6 +951,9 @@ def _validate_accessor_params(dataframe, index, time_index, logical_types, schem
         _check_use_standard_tags(use_standard_tags)
     if schema is not None:
         _check_partial_schema(dataframe, schema)
+        if index is None:
+            # if no index was passed in as a parameter we need to validate the existing index
+            index = schema.index
     if index is not None:
         _check_index(dataframe, index)
     if logical_types:

woodwork/tests/accessor/test_table_accessor.py

@@ -2643,3 +2643,28 @@ def test_infer_missing_logical_types_force_infer(sample_df):
     assert existing_logical_types['age'] is not None
     parsed_logical_types = _infer_missing_logical_types(sample_df, force_logical_types, existing_logical_types)
     assert parsed_logical_types['age'] == Double()
+
+
+def test_validate_unique_index_with_partial_schema():
+    df = pd.DataFrame({'id': [0, 1, 2], 'col': [4, 5, 6]})
+
+    bad_index_df = df.copy()
+    bad_index_df['id'] = pd.Series([1, 1, 1])
+
+    df.ww.init(index='id')
+
+    with pytest.raises(IndexError, match='Index column must be unique'):
+        bad_index_df.ww.init(schema=df.ww._schema)
+
+
+def test_falsy_columns_in_partial_schema(falsy_names_df):
+    if _is_dask_dataframe(falsy_names_df):
+        pytest.xfail('Dask DataFrames cannot handle integer column names')
+    new_df = falsy_names_df.copy()
+
+    falsy_names_df.ww.init(name='df_name')
+
+    new_df.ww.init(schema=falsy_names_df.ww._schema, index=0, time_index='', name=0)
+    assert new_df.ww.index == 0
+    assert new_df.ww.time_index == ''
+    assert new_df.ww.name == 0